openorg-gg / yearn-looks Goto Github PK
View Code? Open in Web Editor NEWLicense: GNU Affero General Public License v3.0
License: GNU Affero General Public License v3.0
Description:
Strategy deposits users $LOOKS into a vault, claims WETH swaps WETH->$LOOKS and restakes.
The $LOOKS emission rewards auto compound in the contract and do not need to be claimed in order to restake.
Commit (hash):
Tag:
Repo: https://github.com/OpenOrg-gg/yearn-looks
Scope: (List link to files)
Due Diligence: https://hackmd.io/@-c0MLh5CTZOQ3HyKamAsvQ/HkhmluZkc
Additional References or Repo (Link to underlying protocols or relevant documents):
Deployed Contract (etherscan link):
Review Ongoing By:
Review Completed By:
Line 154: swapping weth to LOOKS, via UniV2 router. Is this the best approach or should we have MEV protection or a routing protocol?
If this vault ends up being a substantial amount of circulating LOOKS and earning a large portion of the daily rewards it would be a likely target for a lot of front running on that call, and also potentially a lot of slippage.
Line 59: not sure if paused is a standard bool to have there or I accidently picked it up from elsewhere. Is this something the vault or basestrategy need a strategy to have?
In test_shutdown.py I am still failing at line 45 when it calls estimatedTotalAssets().
The test is supposed to compare that the assets deposited still equal roughly the same after the first harvest right after a deposit (when in theory no profit has been made)
However, the assets come out to more than expected. This seems to suggest I'm either:
Or
estimatedTotalAssets()
that suggests that.Would love support in double checking this.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.