openshift-knative / knative-serving-operator Goto Github PK
View Code? Open in Web Editor NEWOBSOLETE: moved to https://github.com/knative/serving-operator
OBSOLETE: moved to https://github.com/knative/serving-operator
I believe, "Install" as a name for the CR is too generic. Currently, its also used by eventing (and Tekton pipeline install operator).
I suggest to rename it to "KnativeServing" and "KnativeEventing" for the corresponding eventing operator.
Why ?
kubectl get install
would need to be always fully qualified with the API group if more than one "install" CR is present (kubectl get installs.serving.knative.de
)kind: KnativeServing
alone then checking the apiVersion: serving.knative.dev/v1alpha1
always together with the kind
.If we want to change that name, we should do it ASAP, i.e. before going to upstream with it.
Since #44, Knative Serving Operator is able to automatically configure RevisionlogURL template in config-observability. However, if openshift-logging/ClusterLogging is started after Knative Serving, Knative Serving Operator does not get notification about the deployment of ClusterLogging. As a result, logUrl is not configured until global resync which can take hours. Existing Knative Serving instanaces should configure logUrl template automatically when openshift-logging is deployed.
https://jira.coreos.com/browse/SRVKS-219
Serving API exposes logUrl in Revision's Status. logUrl can launch visualization app to render logs specific to a Revision. However, logging.revision-url-template must be updated in config-observability (kubectl edit cm config-observability -n knative-serving) before the URL is usable An un-usable URL is shown below.
`host serving-operator]$ k get revision helloworld-8xpcn -n default -o jsonpath='{.status.logUrl}'
When openshift-logging is installed. Kibana hostname is available in openshift route. We should use the host info available and update logURL automatically to improve user experience.
I realise this is an obsolete repo now but I'm looking to test 0.8.1 of Knative serving installed through an operator on OpenShift 4.2 - and I think this is the best place to get started as the 1.0.0 serverless operator is pulling in 0.7.1.
So I checked out the latest tag here (see my notes at https://github.com/a-roberts/openshift42/blob/master/README.md) and see
adams-mbp:knative-serving-operator aroberts$ kgp
NAME READY STATUS RESTARTS AGE
knative-serving-operator-d5dd55cf8-s2zfg 0/1 CrashLoopBackOff 5 5m57s
Logs show
{"level":"error","ts":1571330062.425114,"logger":"cmd","msg":"","error":"routes.route.openshift.io is forbidden: User \"system:serviceaccount:openshift-pipelines:knative-serving-operator\" cannot list resource \"routes\"
This is even with a modification to include
- apiGroups: ["route.openshift.io"]
resources: ["routes"]
verbs: ["get", "list", "update", "delete", "create", "patch"]
for the clusterrole knative-serving-operator. Any ideas please? I'm confident my RBAC addition's pretty good but it can't be - or something else is stopping this?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.