openthread/ot-rtos

OpenThread RTOS, an integration of OpenThread, LwIP, and FreeRTOS.

ot-rtos's Issues

Security Policy violation Binary Artifacts

This issue was automatically created by Allstar.

Security Policy Violation
Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description
Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps
To remediate, remove the generated executable artifacts from the repository.

First 10 Artifacts Found

• third_party/freertos/repo/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Minimal_Windows_Simulator/WinPCap/wpcap.lib
• third_party/freertos/repo/FreeRTOS/Demo/CORTEX_A9_Cyclone_V_SoC_DK/uboot-socfpga/spl/u-boot-spl
• third_party/freertos/repo/FreeRTOS/Demo/CORTEX_A9_Zynq_ZC702/RTOSDemo/src/lwIP_Demo/lwIP_Apps/apps/httpserver_raw_from_lwIP_download/makefsdata/makefsdata.exe
• third_party/freertos/repo/FreeRTOS/Demo/CORTEX_MB9A310_IAR_Keil/config/flashloader/FlashMB9A310.out
• third_party/freertos/repo/FreeRTOS/Demo/CORTEX_MB9B500_IAR_Keil/config/flashloader/FlashMB9BF506.out
• third_party/freertos/repo/FreeRTOS/Demo/Common/drivers/LuminaryMicro/Keil/driverlib.lib
• third_party/freertos/repo/FreeRTOS/Demo/Common/drivers/LuminaryMicro/Keil/grlib.lib
• third_party/freertos/repo/FreeRTOS/Demo/Common/ethernet/lwip-1.4.0/ports/win32/WinPCap/wpcap.lib
• third_party/freertos/repo/FreeRTOS/Demo/H8S/RTOSDemo/Debug/RTOSDemo.x
• third_party/freertos/repo/FreeRTOS/Demo/MicroBlaze_Kintex7_EthernetLite/RTOSDemo/src/lwIP_Demo/lwIP_Apps/apps/httpserver_raw_from_lwIP_download/makefsdata/makefsdata.exe
• Run a Scorecards scan to see full list.

Additional Information
This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.

---

Allstar has been installed on all Google managed GitHub orgs. Policies are gradually being rolled out and enforced by the GOSST and OSPO teams. Learn more at http://go/allstar

This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.

Provide convenient way to generate certificates header

For example, use cmake to generate the header from downloaded certificate files.

mbedcrypto errors when building CLI Test Application for nRF52840

Following the steps to build the CLI test application for Nordics nRF52840 I get the following error when running Cmake:

CMake Error at third_party/mbedtls/CMakeLists.txt:58 (target_link_libraries):
The plain signature for target_link_libraries has already been used with
the target "mbedcrypto". All uses of target_link_libraries with a target
must be either all-keyword or all-plain.

To Reproduce
Running on Windows 10

1. git clone https://github.com/openthread/ot-rtos
2. git submodule update --init
3. mkdir build && cd build
4. cmake .. -DCMAKE_CXX_COMPILER="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe" -DCMAKE_C_COMPILER="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe" -DCMAKE_TOOLCHAIN_FILE=../cmake/arm-none-eabi.cmake -DPLATFORM_NAME=nrf52
   (Note: I am using MSVC Compiler - cl.exe that comes with Visual Studio 2022)

Running this command:

cmake .. -DCMAKE_CXX_COMPILER="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe" -DCMAKE_C_COMPILER="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe" -DCMAKE_TOOLCHAIN_FILE=../cmake/arm-none-eabi.cmake -DPLATFORM_NAME=nrf52

Gives these warnings/errors:

CMake Warning:
Ignoring extra path from command line:

"../cmake/arm-none-eabi.cmake"

-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19044.
PLATFORM_NAME is nrf52
OT_PLATFORM_NAME is nrf52840
CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.24/Modules/ExternalProject.cmake:2251 (message):
Policy CMP0114 is not set: ExternalProject step targets fully adopt their
steps. Run "cmake --help-policy CMP0114" for policy details. Use the
cmake_policy command to set the policy and suppress this warning.

ExternalProject target 'ot' would depend on the targets for step(s)
'configure' under policy CMP0114, but this is being left out for
compatibility since the policy is not set.
Call Stack (most recent call first):
third_party/openthread/CMakeLists.txt:96 (ExternalProject_Add_StepTargets)
This warning is for project developers. Use -Wno-dev to suppress it.

CMake Deprecation Warning at third_party/mbedtls/repo/CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.

Update the VERSION argument value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.

CMake Error at third_party/mbedtls/CMakeLists.txt:58 (target_link_libraries):
The plain signature for target_link_libraries has already been used with
the target "mbedcrypto". All uses of target_link_libraries with a target
must be either all-keyword or all-plain.

The uses of the plain signature are here:

• third_party/mbedtls/repo/library/CMakeLists.txt:145 (target_link_libraries)

-- Configuring incomplete, errors occurred!`

CDC mode support for nRF52840 platform

[mqtt] test mqtt hard fault on nRF52840

Describe the bug
test mqtt command results in hard fault on nRF52840

To Reproduce
Information to reproduce the behavior, including:

1. Git commit id: 11c9594
2. IEEE 802.15.4 hardware platform: nRF52840
3. Build steps:

cmake .. -DCMAKE_TOOLCHAIN_FILE=../cmake/arm-none-eabi.cmake -DPLATFORM_NAME=nrf52 -DCLOUDIOT_DEVICE=my-device -DCLOUDIOT_REGISTRY=my-registry -DCLOUDIOT_PROJECT=ot-cloud-iot -DCLOUDIOT_REGION=us-central1 -DCLOUDIOT_PRIV_KEY=rsa_private.pem

4. Network topology

• RPi OTBR with nRF52840
• nRF52840 DK running ot-rtos

Expected behavior
test mqtt command succeeds as documented.

Console/log output

> ifconfig up
Done
> thread start
Done
> state
child
Done
> test mqtt
> Error during t

After this, the device is stuck in a hard fault and CLI is unresponsive.

Potential duplicate otrTaskNotifyGive() call

ot-rtos/include/openthread/openthread-freertos.h

Line 132 in a6e1c6a

otrTaskNotifyGive(); \

I'm not sure this otrTaskNotifyGive() line is necessary. If a user makes an OpenThread call using the OT_API_CALL(...) macro from another FreeRTOS task and a call to otTaskletsProcess() is required, won't the callback otSysEventSignalPending() be called which also calls otrTaskNotifyGive()? It seems this would duplicate the call to otrTaskNotifyGive(). Not that big of a deal because each call to otrTaskNotifyGive() will just run the application loop an extra time, but if you're running a low-power application you wouldn't really want that.

So as an example: Calling OT_API_CALL(otSetStateChangedCallback) wouldn't actually require a call to otTaskletsProcess() but the macro OT_API_CALL(...) would force a call to that application layer function anyway.

Thanks

The program cannot run continuously under Linux

Hello, use the following command
cmake .. -DPLATFORM_NAME=linux
make -j12
Generate a file ot_cli_linux，If you run directly, the prompt is as follows：
Timer Resolution for Run TimeStats is 100 ticks per second.
It won't work。
GDB debugging found
It works to this function：
static void SuspendThread( pthread_t Thread )。
Then it can't continue to run，How can I continue to run？

Unify ot-rtos prefixes

Is your feature request related to a problem? Please describe.
Currently we are using ot, otr and otRtos prefixes, which is quite confusing.

Describe the solution you'd like
Rename all the prefixes to otRtos and use ot::rtos namespaces for c++ codes.

Enable codecov

Enable code coverage to avoid various issues.

Create a cron job to check this project with the latest OpenThread?

Is your feature request related to a problem? Please describe.
It's possible to find this project is not compatible with the latest OpenThread too late. A daily cron job in Travis could help us to find the incompatibility in time.

Describe the solution you'd like
Create travis job to check with the latest OpenThread.

Additional context
#16