opentok/accelerator-core-ios

Syntax sugar of OpenTok iOS SDK with Audio/Video communication including screen sharing

accelerator-core-ios's Issues

Add a ready-to-use multi-party component

Increase test coverage

App crashes when someone else disconnects from video call

New issue checklist

• I have read all of the README
• I have searched existing issues and this is not a duplicate.

General information

• Library version(s): 1.1.2 Release (#33)
• iOS/Android/Browser version(s): All
• Devices/Simulators/Machine affected: All
• Reproducible in the demo project? (Yes):
• Related issues:

Bug report

Expected behavior

App should disconnect without crashing

...

Actual behavior

App crashes when someone in the video call hangs up

...

Steps to reproduce

Make a video conference with at least two devices. Hang up on one of them, the iOS apps of remaining participants will crash.

...

Crash log? Screenshots? Videos? Sample project?

Can't install with cocoapods using frameworks

New issue checklist

• I have read all of the README
• I have searched existing issues and this is not a duplicate.

General information

• Library version(s): 1.0.4
• iOS/Android/Browser version(s): IOS 10
• Devices/Simulators/Machine affected: N/A
• Reproducible in the demo project? (Yes/No): N/A
• Related issues:

Bug report

My Podfile uses use_frameworks! since I'm using Swift. When trying to install OTAcceleratorCore, I get an error that there are static binaries:

[!] The 'Pods-Project' target has transitive dependencies that include static binaries: (/Users/me/code/project/Pods/OTKAnalytics/OTKAnalytics.framework and /Users/me/code/project/Pods/OpenTok/OpenTok.framework)

Expected behavior

Should I be able to install using frameworks? Not 100% sure honestly.

Actual behavior

pod install errors out

Steps to reproduce

Example Podfile:

target 'TestProj' do
  use_frameworks!

  pod 'OpenTok', '~> 2.10.0'
  pod 'OTAcceleratorCore', '~> 1.0.4'

end

Crash log? Screenshots? Videos? Sample project?

$ pod install
Analyzing dependencies
Downloading dependencies
Installing OTAcceleratorCore (1.0.4)
Installing OTKAnalytics (2.0.0)
Installing OpenTok (2.10.1)
[!] The 'Pods-TestProj' target has transitive dependencies that include static binaries: (/Users/me/code/test-proj/Pods/OTKAnalytics/OTKAnalytics.framework and /Users/me/code/test-proj/Pods/OpenTok/OpenTok.framework)

Question or Feature Request

Should I be able to install with frameworks? If I comment one use_frameworks! then I can't install other pods that I'm using.

Add a ready-to-use one-to-one component

Ensure session is bind to dataSource to avoid invalidity.

- (OTAcceleratorSession*) session { 
    return [_dataSource sessionOfOTMultiPartyCommunicator:self];
}

Improve implementation section for awesome-ios

New issue checklist

• I have read all of the README
• I have searched existing issues and this is not a duplicate.

Question or Feature Request

The only problem I found was the README.md, which lacks an Example Section
I created this iOS Open source Readme Template so you can take a look on how to easily create an Example Section
The only implementation example I found was on how to run the example app, but not actual example code was shown on the README

What are your thoughts? 😄

AppDelegate Crashing for iOS 13 Devices.

This source crashes on running on iOS 13 devices.

This crash is in appdelegate file.

Please test, and provide an update on how to resolve this.

Finish docs on OTVideoView class

Add a sound level indicator