oribuin/eternaltags

A simple tag plugin with RGB Support and without bloat.

eternaltags's Issues

tags.yml does not accept comments in 1.1.0

If you put any comment into tags.yml file (version 1.1.0), the plugin will not load and throw exceptions. The comment stuff worked great in previous version 1.0.12.

Exception log:

org.bukkit.configuration.InvalidConfigurationException: while parsing a block mapping
 in 'string', line 1, column 1:
    _COMMENT_0: ' note'
    ^
expected <block end>, but found '<block mapping start>'
 in 'string', line 11, column 3:
      gm:
      ^

        at org.bukkit.configuration.file.YamlConfiguration.loadFromString(YamlConfiguration.java:59) ~[patched_1.17.1.jar:git-Paper-409]
        at org.bukkit.configuration.file.FileConfiguration.load(FileConfiguration.java:160) ~[patched_1.17.1.jar:git-Paper-409]
        at org.bukkit.configuration.file.YamlConfiguration.loadConfiguration(YamlConfiguration.java:217) ~[patched_1.17.1.jar:git-Paper-409]
        at xyz.oribuin.eternaltags.libs.rosegarden.config.CommentedFileConfiguration.reloadConfig(CommentedFileConfiguration.java:52) ~[EternalTags-1.1.0-sgmc.jar:?]
        at xyz.oribuin.eternaltags.manager.TagsManager.loadTags(TagsManager.java:80) ~[EternalTags-1.1.0-sgmc.jar:?]
        at xyz.oribuin.eternaltags.manager.TagsManager.reload(TagsManager.java:67) ~[EternalTags-1.1.0-sgmc.jar:?]
        at java.util.LinkedHashMap$LinkedValues.forEach(LinkedHashMap.java:647) ~[?:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.RosePlugin.reload(RosePlugin.java:154) ~[EternalTags-1.1.0-sgmc.jar:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.command.command.ReloadCommand.execute(ReloadCommand.java:20) ~[EternalTags-1.1.0-sgmc.jar:?]
        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
        at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
        at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.command.framework.RoseCommandWrapper.executeCommand(RoseCommandWrapper.java:293) ~[EternalTags-1.1.0-sgmc.jar:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.command.framework.RoseCommandWrapper.runCommand(RoseCommandWrapper.java:282) ~[EternalTags-1.1.0-sgmc.jar:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.command.framework.RoseCommandWrapper.execute(RoseCommandWrapper.java:221) ~[EternalTags-1.1.0-sgmc.jar:?]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:159) ~[patched_1.17.1.jar:git-Paper-409]
        at org.bukkit.craftbukkit.v1_17_R1.CraftServer.dispatchCommand(CraftServer.java:869) ~[patched_1.17.1.jar:git-Paper-409]
        at org.bukkit.craftbukkit.v1_17_R1.CraftServer.dispatchServerCommand(CraftServer.java:832) ~[patched_1.17.1.jar:git-Paper-409]
        at net.minecraft.server.dedicated.DedicatedServer.handleConsoleInputs(DedicatedServer.java:529) ~[patched_1.17.1.jar:git-Paper-409]
        at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:491) ~[patched_1.17.1.jar:git-Paper-409]
        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1483) ~[patched_1.17.1.jar:git-Paper-409]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1282) ~[patched_1.17.1.jar:git-Paper-409]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[patched_1.17.1.jar:git-Paper-409]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: org.yaml.snakeyaml.parser.ParserException: while parsing a block mapping
 in 'string', line 1, column 1:
    _COMMENT_0: ' note'
    ^
expected <block end>, but found '<block mapping start>'
 in 'string', line 11, column 3:
      gm:
      ^

        at org.yaml.snakeyaml.parser.ParserImpl$ParseBlockMappingKey.produce(ParserImpl.java:617) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.parser.ParserImpl.peekEvent(ParserImpl.java:165) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.comments.CommentEventsCollector$1.peek(CommentEventsCollector.java:59) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.comments.CommentEventsCollector$1.peek(CommentEventsCollector.java:45) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.comments.CommentEventsCollector.collectEvents(CommentEventsCollector.java:140) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.comments.CommentEventsCollector.collectEvents(CommentEventsCollector.java:119) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.composer.Composer.composeScalarNode(Composer.java:221) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.composer.Composer.composeNode(Composer.java:191) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.composer.Composer.composeValueNode(Composer.java:313) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.composer.Composer.composeMappingChildren(Composer.java:304) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.composer.Composer.composeMappingNode(Composer.java:288) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.composer.Composer.composeNode(Composer.java:195) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.composer.Composer.getNode(Composer.java:115) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.composer.Composer.getSingleNode(Composer.java:146) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.constructor.BaseConstructor.getSingleData(BaseConstructor.java:151) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.Yaml.loadFromReader(Yaml.java:490) ~[patched_1.17.1.jar:git-Paper-409]
        at org.yaml.snakeyaml.Yaml.load(Yaml.java:416) ~[patched_1.17.1.jar:git-Paper-409]
        at org.bukkit.configuration.file.YamlConfiguration.loadFromString(YamlConfiguration.java:57) ~[patched_1.17.1.jar:git-Paper-409]
        ... 24 more```

Can you support the title or mysql synchronization, otherwise you need to copy tag.yml to each sub-server every time, which is very troublesome

Can you support the title or mysql synchronization, otherwise you need to copy tag.yml to each sub-server every time, which is very troublesome

Minimessage Support

Hey, it would be cool if the plugin would also support MiniMessage formatting, since it is the new standard on paper servers.

Allow change bottom menu MATERIAL

Please allow in the config to change the Material of the bottom in the menu, current default is some glass panel and I could not find anywhere to change these glasses.

It is called fillerItem in your code.

Thank you <3

GUI title placeholders aren't present on the initial open

Here, the title should be EternalTags | 1/19. It does update and show correctly after the player has interacted with the menu.

Hope you can add features

Hope you can add features

1. Obtained by consuming gold coins
2. Consume designated items
3. Obtaining conditions (gold coins ≥ 1000) (designated items ≥ 64) (whether the group can be obtained)

The plugin will report an error when loading localized files, as will the use of the reload command

The server is Purpur 1.18.2

[04:06:28 INFO]: [EternalTags] Enabling EternalTags v1.2.1-SNAPSHOT
[04:06:28 INFO]: [EternalTags] Initializing using RoseGarden v1.2.5
[04:06:28 INFO]: [EternalTags] Data handler connected using SQLite.
[04:06:28 ERROR]: Cannot load configuration from stream
org.bukkit.configuration.InvalidConfigurationException: expected '<document start>', but found '<block mapping start>'
 in 'reader', line 2, column 1:
    _COMMENT_0: ' Plugin Message Prefix'
    ^

        at org.bukkit.configuration.file.YamlConfiguration.loadFromString(YamlConfiguration.java:104) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:
?]
        at org.bukkit.configuration.file.FileConfiguration.load(FileConfiguration.java:160) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.configuration.file.YamlConfiguration.loadConfiguration(YamlConfiguration.java:333) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.j
ar:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.config.CommentedFileConfiguration.<init>(CommentedFileConfiguration.java:26) ~[EternalTag
s-1.2.1-SNAPSHOT.jar:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.config.CommentedFileConfiguration.loadConfiguration(CommentedFileConfiguration.java:95) ~
[EternalTags-1.2.1-SNAPSHOT.jar:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.locale.YamlFileLocale.<init>(YamlFileLocale.java:20) ~[EternalTags-1.2.1-SNAPSHOT.jar:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.locale.provider.JarResourceLocaleProvider.getLocales(JarResourceLocaleProvider.java:55) ~
[EternalTags-1.2.1-SNAPSHOT.jar:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.manager.AbstractLocaleManager.getJarResourceLocales(AbstractLocaleManager.java:140) ~[Ete
rnalTags-1.2.1-SNAPSHOT.jar:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.manager.AbstractLocaleManager.reload(AbstractLocaleManager.java:131) ~[EternalTags-1.2.1-
SNAPSHOT.jar:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.RosePlugin.getManager(RosePlugin.java:213) ~[EternalTags-1.2.1-SNAPSHOT.jar:?]
        at java.util.ArrayList.forEach(ArrayList.java:1511) ~[?:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.RosePlugin.reload(RosePlugin.java:175) ~[EternalTags-1.2.1-SNAPSHOT.jar:?]
        at xyz.oribuin.eternaltags.EternalTags.reload(EternalTags.java:60) ~[EternalTags-1.2.1-SNAPSHOT.jar:?]
        at xyz.oribuin.eternaltags.libs.rosegarden.RosePlugin.onEnable(RosePlugin.java:104) ~[EternalTags-1.2.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:370) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:541) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_18_R2.CraftServer.enablePlugin(CraftServer.java:560) ~[purpur-1.18.2.jar:git-Purpur-1632]
        at org.bukkit.craftbukkit.v1_18_R2.CraftServer.enablePlugins(CraftServer.java:474) ~[purpur-1.18.2.jar:git-Purpur-1632]
        at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:670) ~[purpur-1.18.2.jar:git-Purpur-1632]
        at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:437) ~[purpur-1.18.2.jar:git-Purpur-1632]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:352) ~[purpur-1.18.2.jar:git-Purpur-1632]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1180) ~[purpur-1.18.2.jar:git-Purpur-1632]
        at net.minecraft.server.MinecraftServer.lambda$spin$1(MinecraftServer.java:321) ~[purpur-1.18.2.jar:git-Purpur-1632]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: org.yaml.snakeyaml.parser.ParserException: expected '<document start>', but found '<block mapping start>'
 in 'reader', line 2, column 1:
    _COMMENT_0: ' Plugin Message Prefix'
    ^

        at org.yaml.snakeyaml.parser.ParserImpl$ParseDocumentStart.produce(ParserImpl.java:259) ~[snakeyaml-1.30.jar:?]
        at org.yaml.snakeyaml.parser.ParserImpl.peekEvent(ParserImpl.java:166) ~[snakeyaml-1.30.jar:?]
        at org.yaml.snakeyaml.parser.ParserImpl.checkEvent(ParserImpl.java:156) ~[snakeyaml-1.30.jar:?]
        at org.yaml.snakeyaml.composer.Composer.getSingleNode(Composer.java:145) ~[snakeyaml-1.30.jar:?]
        at org.yaml.snakeyaml.Yaml.compose(Yaml.java:575) ~[snakeyaml-1.30.jar:?]
        at org.bukkit.configuration.file.YamlConfiguration.loadFromString(YamlConfiguration.java:102) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:
?]
        ... 24 more
[04:06:28 WARN]: [EternalTags] ================================================
[04:06:28 WARN]: [EternalTags]  You are currently running a DEVELOPMENT BUILD!
[04:06:28 WARN]: [EternalTags]  These types of builds are not meant to be run
[04:06:28 WARN]: [EternalTags]  on a production server, and are not supported.
[04:06:28 WARN]: [EternalTags] ================================================
[04:06:28 INFO]: [PlaceholderAPI] Successfully registered expansion: eternaltags [1.2.1-SNAPSHOT]

Error with RoseGarden

Hello,
I've updated EternalTags to the latest version available on spigotmc, and i've this error when the server start and when i reload the plugin:

[13:18:56 INFO]: [EternalTags] Enabling EternalTags v1.3.0
[13:18:56 INFO]: [EternalTags] Data handler connected using SQLite.
[13:18:56 WARN]: xyz.oribuin.eternaltags.libs.rosegarden.manager.AbstractLocaleManager$LocaleException: Missing locale string: command-tags-description
[13:18:56 WARN]: at EternalTags-1.3.0.jar//xyz.oribuin.eternaltags.libs.rosegarden.manager.AbstractLocaleManager.getErrorMessage(AbstractLocaleManager.java:362)
[13:18:56 WARN]: at EternalTags-1.3.0.jar//xyz.oribuin.eternaltags.libs.rosegarden.manager.AbstractLocaleManager.getCommandLocaleMessage(AbstractLocaleManager.java:223)
[13:18:56 WARN]: at EternalTags-1.3.0.jar//xyz.oribuin.eternaltags.libs.rosegarden.manager.AbstractLocaleManager.getCommandLocaleMessage(AbstractLocaleManager.java:206)
[13:18:56 WARN]: at EternalTags-1.3.0.jar//xyz.oribuin.eternaltags.libs.rosegarden.command.framework.RoseCommandWrapper.register(RoseCommandWrapper.java:108)
[13:18:56 WARN]: at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
[13:18:56 WARN]: at EternalTags-1.3.0.jar//xyz.oribuin.eternaltags.libs.rosegarden.manager.AbstractCommandManager.reload(AbstractCommandManager.java:31)
[13:18:56 WARN]: at EternalTags-1.3.0.jar//xyz.oribuin.eternaltags.libs.rosegarden.RosePlugin.getManager(RosePlugin.java:222)
[13:18:56 WARN]: at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
[13:18:56 WARN]: at EternalTags-1.3.0.jar//xyz.oribuin.eternaltags.libs.rosegarden.RosePlugin.reload(RosePlugin.java:182)
[13:18:56 WARN]: at EternalTags-1.3.0.jar//xyz.oribuin.eternaltags.EternalTags.reload(EternalTags.java:56)
[13:18:56 WARN]: at EternalTags-1.3.0.jar//xyz.oribuin.eternaltags.libs.rosegarden.RosePlugin.onEnable(RosePlugin.java:113)
[13:18:56 WARN]: at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:287)
[13:18:56 WARN]: at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:188)
[13:18:56 WARN]: at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:104)
[13:18:56 WARN]: at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:507)
[13:18:56 WARN]: at org.bukkit.craftbukkit.v1_20_R3.CraftServer.enablePlugin(CraftServer.java:653)
[13:18:56 WARN]: at org.bukkit.craftbukkit.v1_20_R3.CraftServer.enablePlugins(CraftServer.java:564)
[13:18:56 WARN]: at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:675)
[13:18:56 WARN]: at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:435)
[13:18:56 WARN]: at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java:346)
[13:18:56 WARN]: at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1146)
[13:18:56 WARN]: at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:323)
[13:18:56 WARN]: at java.base/java.lang.Thread.run(Thread.java:1583)
[13:18:56 INFO]: [PlaceholderAPI] Successfully registered internal expansion: eternaltags [1.3.0]

Logs link: https://mclo.gs/JEkQ9uV

SLF4J Error on load

Console error after Paper-399 L4J vulnerability fix

[20:09:07 ERROR]: [EternalTags] [STDERR] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
[20:09:07 WARN]: Nag author(s): '[Oribuin]' of 'EternalTags' about their usage of System.out/err.print. Please use your plugin's logger instead (JavaPlugin#getLogger).
[20:09:07 ERROR]: [EternalTags] [STDERR] SLF4J: Defaulting to no-operation (NOP) logger implementation
[20:09:07 ERROR]: [EternalTags] [STDERR] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Feature Request

Sounds for

removing a tag you have on

equipping a tag

adding a tag to favorites

opening the favorite menu

Unintuitive GUI behavior

Can you make the GUI that when you click on the tag, it remove the tag rather than equip the tag again? or tell them that they cannot reequip the same tag

I know there is a clear tag button but it's unintuitive and confuse players.

Also when making addon for the plugin, it can lead to weird state so I have to becareful everytime I listen to the TagEquipEvent

Also why the TagUnequipEvent not give the Tag that's removed? Basically its some what useless

Thanks