oscarmlage/bofhers

#BOFHers project

bofhers's Issues

"0" text triggers an !addquote event

https://github.com/oscarmlage/bofhers/blob/master/app/Http/Controllers/TelegramController.php handles incoming text by creating a switch with the received text:

bofhers/app/Http/Controllers/TelegramController.php

Lines 74 to 79 in fa16b54

	if (in_array($this->chat_id, $allowed_channels)) {
	switch ($this->text) {
	case '/menutifu':
	$this->sendMessage('Aquí debería ir el menú con los comandos disponibles');
	//$this->showMenu();

The !addquote event entry within the switch is handled like this:

bofhers/app/Http/Controllers/TelegramController.php

Lines 98 to 112 in fa16b54

	// Save new quotes
	case ( preg_match( '/!addquote.*/', $this->text ) ? true : false ):
	if(trim(ltrim($this->text, '!addquote')) == '') {
	$this->sendMessage('❌ Pezqueñines no, gracias... ¡hay que dejarlos crecer! 🤷');
	break;
	}
	$data = [
	'chat_id'=>$this->chat_id,
	'nick'=>$this->username,
	'first_name'=>$this->first_name,
	'last_name'=>$this->last_name,
	'telegram_user_id'=>$this->telegram_user_id,
	'quote'=>trim(ltrim($this->text, '!addquote')),
	'active'=>0,
	];

As the previous preg_match returns 0 on a non-match, a text 0 would wrongly trigger an !addquote event. Text should be verified as valid before using the regexp.

/help parameter should ignore slashes when querying a command's help

This works:

/help addquote

This doesn't:

/help /addquote

The second not working is confusing and it should.

Requesting access to the quote DB

So I can fix some typos 🦈🦈🦈

Covid

COVAD! cada día te quiero más

Edit quote object and command !quote

in the !addquote command, allow something like
!addquote TEXT [tag]

if you send !quote tag, it shows quotes in that quote-tag-list.

This allows things like !quote insult !quote joke !quote rusa, an so on.

With this variaton, you can have some of the others issues solved (like the insult, salutation, ie)

Add TELEGRAM_WEBHOOK_KEY to /webhook route

Show list of channels in the front page

Autovalidate quotes

It's needed a bot admin to validate the quotes. As the groups count grows, it could be overwhelming for the admins.

If there is a flag to mark a group as auto, the quotes will be added as validated.

Don't store the messages, only count

Don't need the message itself, for stat purposes it should work with just a counter

Limit user requests

Think about a limit or something for people asking for many commands in the same minute.

!trivia

Refactor !commands to use the Telegram command API

As of now, the bot's is parsing every received text message in order to determine if they are a command or not.

Is this by design? Telegram's commands api allows the bot to receive commands without having to parse any incoming text. It could also allow it to not depend on having to listen too all messages if at some point in the future privacy reasons force us to reevaluate #12

It's also helpful because it provides autocompletion, descriptions and prevents us from having to worry about parsing text, which might up bringing more issues.

I want to add category support for !addquote and !quote and I could benefit from the command API if this is not a design choice.

Convert get-me, set-hook, del-hook... in cli commands

And delete the routes (not even with TELEGRAM_WEBHOOK_KEY in URL)

Add TifuBot help

Add a command that shows some help to the users: !help

!quote uses different condicional while rotating quotes

When Tifu says a quote in a channel we pick only active ones and mark the randomly selected one as inactive (TelegramController.php around line 120):

$quote = Quote::where('chat_id', $this->chat_id)->where('active', 1)

but then in the conditional (just to see if all quotes are inactives) we're not filtering for channel:

if(Quote::where('active', 1)->count() == 0)

So if quotes are over in a channel, there is no quote to send and it crashes because $quote->quote does not always exist.

People in "BOFHers makers" doesn't want the hourly quote

Send the hourly quote only to "BOFHers" channel.

Add congratulations quote

Add "congratulation" quotes to be used in birthday of the users (take in account a wildcard for Valkrieg).

Rotating quotes

tienes un campo "active" 0/1, solo has de crear el estado -1. Cuando lances !quote, pones active=-1 en el quote elegido. Y luego metes un Si el where de active = 1 devuelve 0, pones todos los -1 a 1.

!random_insult

Remove temporary debug logs

allow adding gif to quotes

Use !addquote @gif word to get the first result from @gif and return it as quote.

Scheduled quote is not updating quote active status

When the scheduled run for a random quote sends a text it is not doing neither of:

• Picking only those who have not been seen yet.
• Updating the quote to set it as "already seen".

Documentation on how to create a test environment

Right now testing changes for the app is quite painful because:

• There is no easy way to do it.
• Even if you deploy local services, there's no documentation on how to set up the application.
• There's also no documentation on how to set up Telegram's integration.

Ideally it should be as easy as "fill a configuration file" and "click a button" so that making changes is less painful both for new and veteran contributors.

!veo-veo

!saludo_in_the_morning

tu ya sas cual es

Improve software model

• Increase the size of the field (the type in this case)
• Add a link

Add quotes to TifuBot

Add quotes related commands:

• !addquote
• !quote

Needs a proper db table and, maybe, a command for schedule in Kernel to be able to send a random quote in a random hour from 7am to 2am (i.e.).

Add !eval so we can easily ssh into your server

... and maybe install arch-testing?

Add ruskifilter

Every time user @alexandernst says something with specific terminations (previously analyzed) trigger proteo_plancha_amif.png sticker.