osgi/osgi.security-tests

Security Best Practices Tests for OSGi Framework Implementations

OSGi

This is the main git repository for the OSGi specifications, implementations and TCKs. It is a Bnd Workspace model build.

Build

See CONTRIBUTING for information on checking out the repo and building.

Draft Specifications

The GitHub Actions build "GitHub Pages" job will publish the draft specifications into the repo's gh-pages branch. So you can view the draft specifications for the osgi/osgi repo:

• Core
• Compendium

In your fork, just add core/ or cmpn/ to the end of your fork's GitHub Pages URL. For example:

https://<username>.github.io/osgi/core/

More Information

For more information see the OSGi Specification Project pages at Eclipse: https://projects.eclipse.org/projects/technology.osgi

osgi.security-tests's Issues

Major problems with test structure.

Pull Request #16 was reverted in the recent commit 884923b Which means that the tests no longer use a sensible JUnit structure.

Also there are several other issues with the test structure:

• The use of a boolean to encapsulate pass/fail semantics is completely against the JUnit model (see https://github.com/osgi/osgi.security-tests/blob/master/org.osgi.security.sysatt110.test/src/org/osgi/security/sysatt110/test/Activator.java#L22) This boolean is just used to do test logging. This should be implemented correctly using a Verifier rule (see http://junit.org/junit4/javadoc/latest/org/junit/rules/Verifier.html)
• The code is no longer present, but previously Security manager checks were being made as part of individual tests. This should be processed in a common superclass using an @after fixture to avoid polluting tests with other logic.

The current state of the tests fd51af6 is a huge regression from the previous state.