Adapt "Missing primary Wikipedia tag" for Brazil

[osm-fr]

Adapt "Missing primary Wikipedia tag" for Brazil

[jgpacker]

In my opinion, this kind of fix shouldn't be recommended at all.

The wiki page for the key wikipedia=* itself recommends adding secondary wikipedia links in some cases, and this recommendation is there for a long time.

I believe this shouldn't be seen as some kind of error.
On the other hand, I don't think there is any case where more than 2 or 3 wikipedia:xy=* variants could be justified.

[frodrigo]

This checking is justified. But you're right, extra wikipedia:xy tag can be useless, but it can be checked on another analysis. See #18

[frodrigo]

I just checked it. When there is multiple "wikipedia:LANG" it propose an alternative fix for each language. So, it's right for me.

[naoliv]

Well, somebody automatically fixed (but not correctly in all cases) those issues in Brazil, but what we had was an object with only wikipedia:en=X and wikipedia:pt=X (ie, the object didn't have a primary wikipedia=LANG:X tag)

osmose was suggesting to use wikipedia=en:X instead the proper wikipedia=pt:X for Brazil.

The primary wikipedia key should always be pt in Brazil and not en like osmose was suggesting.

[frodrigo]

I no locate an issue like you describe.
But in the code it produce 2 alternates solutions. I just check it.

[naoliv]

I will create one object like this in OSM and then I will show you in 1 or 2 days :-)

[naoliv]

Well, actually it wasn't necessary to create an object...
Using this example: http://www.openstreetmap.org/node/34582421

See that we have a lot of wikipedia=LANG:X but not a primary wikipedia:LANG=X

osmose suggests this:

See that it's suggesting to use wikipedia=en:Sugarloaf instead wikipedia=pt:Complexo_do_Pão_de_Açúcar

In Brazil it should always use/suggest wikipedia:pt when available, instead wikipedia:en

I hope it's clearer now :-)

[frodrigo]

So you're right. There is something wrong.

[frodrigo]

There are multiple errors, each with one fix, in place of one error with multiple fixes.

[frodrigo]

commit 3f10546 (HEAD, master)
Fix 'Missing primary Wikipedia tag' with multiple secondary tags

[frodrigo]

Done
http://osmose.openstreetmap.fr/map/#zoom=18&lat=-22.949779&lon=-43.156288&layer=Mapnik&overlays=FFFFFFFFFFFFFFFFFFFT&item=xxxx&level=1%2C2%2C3&tags=&fixable=

[naoliv]

I fear one thing here: people will use the first suggestion to fix the key (and make en the primary language for wikipedia).
Isn't it possible to suggest only one fix (pt for Brazil) or at least make pt the first option?

[frodrigo]

Sort fix in TagFix_Wikipedia, country language first, github#14
ad56668

[frodrigo]

Checked. It works.