osm-fr/osmose-backend

Part of osmose that runs the analysis, and send the results to the frontend.

Backend part of the Osmose QA tool

This is the part of Osmose which analyses OSM and sends the results to the frontend. This works as follows:

• an .osm.pbf extraction is downloaded
• analyses are run directly on the .osm.pbf file, or on the database
• results of the analyses are uploaded to the frontend
• by default, the database is purged

Analysers can be build in many ways:

• With MapCSS rules validating each OSM objects: plugins/*.mapcss and JOSM MapCSS core and some contrib rules.
• With Python code validating each OSM objects: plugins.
• With SQL/PostGIS queries on the Osmosis database: analysers/analyser_osmosis_*.py.
• By configuring a comparator of OpenData and OSM objects: analysers/analyser_merge_*.py.

Installation

The default way to setup Osmose Backend is through Docker. Look at the docker/README.md.

You can also install manually on a debian distribution INSTALL.md.

Run

Look at the osmose_run.py help for options

osmose_run.py -h

Contributing

Setup a Docker install and follow the "Develop on Osmose with docker" guide.

Read the additional contribution guidelines.

osmose-backend's Issues

Item 8031 - Added operator:type tag in the integration proposal

Is it possible to include in the tags proposed by the tag operator:type ?

Information must be taken from the name of the institution:

• Contains "public" -> operator:type=public
• Contains "privé", "privée", "saint", "sainte" -> operator:ype=private

Item 2060 - Should associatedStreet relations take into account roundabouts?

Osmose rises a class 7 issue when an associatedStreet relation includes different names.

However, in this example (http://osmose.openstreetmap.fr/fr/error/3880380933), the relation "Route de Nevers" encompasses several streets named "Route de Nevers" and 2 roundabouts named "Porte de Nevers".

Maybe the relation should not include the roundabouts or the Osmose test should be modified. I haven't found info on the wiki (http://wiki.openstreetmap.org/wiki/Relation:associatedStreet).

Item 8031 - Main Tag to integrate kindergartens

Osmose proposes to integrate kindergartens with the tag amenity=school instead amenity=kindergarten: is this normal?
(see http://wiki.openstreetmap.org/wiki/FR:Tag:amenity%3Dschool)

I understand that the choice of the main tag kindergartens was under discussion for a time, but that seems over.

Missing Parent Tag for all highways with bicycle = yes

We (Belgian Mappers) noticed that all highways in Belgium that are tagged with bicycle = yes, are now marked with "Missing parent tag". Osmose demands to add route = bicycle.

We believe that this is not correct.

Detect missing objet by French geodesic comment

Remove the abbreviations of "Route Forestière" in France

In forests, locate ways highway=* with name="RF *" and offer the user to change the name to "Route Forestière *"

Feature request: detect way "name" tag with selected words

Hi,

I request a rule to detect ways with "name" tag starting with words: Calle, Camino, Avenida, Plaza, or Pasaje. These are Spanish words for type of way.

Such rule should be applied to Catalonia, Illes Balears (Spanish regions), and Andorra, where Catalan languages is preferred.

Some mappers use Spanish names for ways, but Catalan community use Catalan names for "name" and "name:ca" tags and Spanish names for "name:es" tag.
See this Overpass-turbo query
http://overpass-turbo.eu/s/at7

There are two Spanish regions, Comunitat Valenciana and Aragon, where language preference is city based. So, I don't know if it's possible to develop such rule for Valencian and Aragon regions.

Some feature can be on negative layer

Test landuse and other must be on layer 0.

Detect useless restriction relation

• because oneway already forbid it
• because country law forbid it (u-turn on street or on junction)

Detect power node share with other feature type

Like power node shared with highway

addr:interpolation with node not in the same street

Highway 7170/1 relation is disturbing

Relation is not implied in the issue.
More over, when loading with link "josm zone", josm loads and zoom on relation, not on the area.

Feature request check *_link roads

Check *_link if it connects 2 roads with same class, then this *_link road must have same class with roads.

Example (left is wrong):

"Highway intersecting building" false positives

I am seeing some false positivies with the "Highway intersecting building" test, when a highway pass below a building=roof + layer=1 (on gas stations, tolls, etc)
Since the highway has an implicit layer=0, there shouldn't be a warning about this.

Improvement for "Unfinished power line" test

In this area there are some messages about "Unfinished power line"

Reading http://wiki.openstreetmap.org/wiki/Osmose/errors#7040 it seems that the test searchs for power=substation or power=generator, but we have a deprecated power=sub_station at the area.

This could be improved with two steps:

• ignore power lines ending at power=sub_station
• give a warning about the deprecated power=sub_station tag.

Since the problem is in fact with the deprecated sub_station value, we shouldn't give any messages about the power lines.

Feature request: name and name:* mistmaches

1. osmose should warn user when name:* tag (with default language for this country) mismatches name=* tag.
2. osmose should warn user when name= tag is empty but tag with default language in this country provided.

See http://wiki.openstreetmap.org/wiki/Multilingual_names for country-specific info and default languages.

Not testing maxheight for ways under bridges

It seems that it's not testing for missing maxheight on ways that pass under bridges.
For example, this way http://www.openstreetmap.org/way/42370410 should have a maxheight tag, since there is a bridge/viaduct above it.

indention behind 3161 parking lane 'missing access to parking'?

Now that I've gotten some warnings about 3161 parking lane 'missing access to parking' and nothing is documented in the wiki, i want to ask you: what is your indention behind this issue?

Just an example: 273144424 and related bing maps. How should i tag/map this parking area?

If you prefer parking:lane, where should i tag operator, surface, and so on? There's nothing mentioned about it in wiki for parking:lane.

Another opportunity could be to share the two corner-nodes with the highway, but this isn't best practice.

Test for incomplete objects

Could osmose test for incomplete objects?
For example, objects having only:

• name
• name + area=yes
• area=yes

Node like way, false positive for proposed or construction

ti's about analyser_osmosis_node_like_way
exemple
when highway=proposed is on way and nodes
but the tag proposed is different for way and node

=> in sql20 ,
" where ways.tags->t = nodes.tags->t"
add something like this ?
" and nodes.tags not in (proposed,construction)"

No more "moneo:loading" in French post offices

The Moneo payment service is to be discontinued this month, and loading Moneo cards isn't possible since July 1st (http://www.metronews.fr/conso/fin-de-moneo-date-limite-de-paiement-rechargement-remboursement-du-solde/mofq!6cB8lcEb0qQo/).

Osmose should remove the key "moneo:loading" from its post office layer.

False positives "Invalid area postcode * for country code BR"

I am also seeing some "Invalid area postcode * for country code BR" false positives.

This regex gives what is valid here:

^[0-9]{2}\.?[0-9]{3}(-| )?[0-9]{3}$

Adapt "Missing primary Wikipedia tag" for Brazil

On objects that have both wikipedia:en=X and wikipedia:pt=X, the "Missing primary Wikipedia tag" test suggests a fix excluding wikipedia:en and adding wikipedia=en:

It should use the pt variant for this, removing wikipedia:pt and making it wikipedia=pt

delete unused string from translation files

there is an old message in transifex that looks like an unused typo "Intersection of unrelatedgit highway and power objects"

new analyse to detect duplicated import of nodes

it's about detect duplicated nodes.
this 2 changest are from the same user who upload 2 times the same data
https://www.openstreetmap.org/changeset/34273139
https://www.openstreetmap.org/changeset/34273083

i try this

sql10 = """
-- node which is not in way and relation
CREATE TEMP TABLE {0}onlynodes AS
SELECT
id,tags,geom
FROM
nodes
LEFT JOIN way_nodes ON
nodes.id = way_nodes.node_id
LEFT JOIN relation_members ON
nodes.id = relation_members.member_id and
relation_members.member_type = 'N'
WHERE
way_nodes.node_id IS NULL AND
relation_members.member_id IS NULL
;
"""

sql11 = """
CREATE INDEX {0}onlynodes_idx ON {0}onlynodes USING gist(geom);
"""

sql12 = """
SELECT
b1.id AS id1,
-- b2.id AS id2,
ST_AsText(b1.geom)
FROM
{0}onlynodes AS b1,
{1}onlynodes AS b2
WHERE
b1.id > b2.id AND
b1.geom && b2.geom AND
ST_Equals(b1.geom, b2.geom) AND
((b1.tags @> b2.tags ) and (b2.tags @> b1.tags ))
;
"""

Osmose "Missing object kind" is not return for golf

in http://osmose.openstreetmap.fr/fr/errors/?item=2110, the error has been removed for isolated golf key

I have see this line https://github.com/osm-fr/osmose-backend/blob/master/plugins/TagFix_MultipleTag.py#L40

I think the modification isn't correct because osmose should proposed sport=golf | leisure=golf_course or other leisure with golf terms if golf=* exist

sport and leisure already exist in name_parent. Adding golf isn't a good idea

Check for junction=roudabout with area=yes

Non sens and induce renderer and routing problem.

Error 5030 - two names

Hi,

With error 5030, there is a problem in bilingual areas. There all street names, street signs, oficial building names,... must be written in both languages. Common practice is to write in name field in both languages separated with / and also in both local languages.

Example:
way 277453150
name Razbremenilnik / Canale di scolo
name:it Canale di scolo
name:sl Razbremenilnik

So my suggestion is, that in case of / you check for both sides if they exists in name:xx tag and in such case don't report this as an error.

Same problem applies to error 5060

BTW: Can you add default language for Slovenia.

File osmose-backend/osmose_config.py Line 384

default_country("europe", "slovenia", 218657, {"country": "SI", "language": "sl", "proj": 32633}, download_repo=GEOFABRIK)

Test for turning restrictions with duplicated to/from

Sorry if this is already tested, but could osmose test for turning restrictions that have the same way as both from and to?

marker.subtitle %s not replaced

Exemple :

key	value
marker.class	3040
marker.elems	way210191694
dynpoi_class.title	Bad value in a tag
marker.subtitle	Bad value for service=%s

Allow water way to connect to drain

Improving names junction in forest

In forests, locate nodes at the intersection of ways highway=* and only with a tag name=*. Propose to add junction=yes with the following message to the user: "junction=yes missing at junction"

Support request: How to use it

I would like to work on a new analyser. How can I test my new analyser?

• I cloned the repository
• I've installed all the dependencies and extensions
  So how can I "run" my analyser? How can I check out wether I like its result?

8050: check disused:railway=station/halt to match disused stations and halts...

Error 3030, Class 737787355 "shop"

Hi,

shop=fishing is good tag for shop with fishing equipment. http://wiki.openstreetmap.org/wiki/Tag:shop=fishing
and should not be reported as error.

Can I correct (remove) it on http://wiki.openstreetmap.org/wiki/User:FrViPofm/TagwatchCleaner#s_2 or should you make changes there?

Building rond : proposer aussi man_made=windmill

Je suis désolé de ne pas savoir si c'est un problème de backend ou de frontend.

Lorsqu'on osmose détecte un building générique (building=yes) rond, la liste des remplacements proposés devrait aussi contenir "man_made = windmill"

Feature request: wikipedia tag normalisation

Similarly to JOSM feature "there amenity=school inside amenity=school" this feature should warn user when there duplicate wikipedia= tag. Example: http://www.openstreetmap.org/changeset/26106941

Bonus points if this check will understand multi-language links (i.e. it will recognize fr:Canal de Suez and en:Suez Canal as same link).

Feature request: check "name:es" without "name:ca"

Hi,

I request a custom local rule to check objects (nodes, ways, and relations) with "name:es" but lacking "name:ca".

This rule can be applied to Catalonia, Comunitat Valenciana, Illes Balears (Spanish regions), and Andorra, where Catalan is preferred language for "name"

Item 8031 - Update French Education Nationale files

New schools to integrate geocoding is it possible? (with BANO / ADDOK)

This will allow both to school integration and validates the address.

Support addr:interpolation in addr:housenumber check

Support addr:interpolation in "addr:housenumber without addr:street, addr:district, addr:quarter, addr:suburb or addr:place must be in a associatedStreet relation" (2060/1)
analyser_osmosis_relation_associatedStreet.py

Broken highway continuity

Broken highway continuity should probably ignore ways that connect with highway=proposed and highway=construction. There are too many false alarms like these.

Park and ride not linked to any streets; it will not be usable.

Feature request: detect duplicate object by names

Warn user when there similarly named features within proximity.

osmose should warn user about feature with same name, provide link to http://wiki.openstreetmap.org/wiki/One_feature,_one_OSM_element and suggest to use relation type=multipolygon or type=site.

Bonus points for transliterated text (Ελληνική Δημοκρατία - Hellēnikē Dēmokratia etc)
Bonus points for advanced string comparison features (support for articles, mixed case, umlaut)
Bonus points for fuzzy matching, preferably done as separate check/process.

Feature request: check buiding= tag mismatches

Case 1: way tagged as amenity=kindergarten contains (way/multipolygon) building=school
Expected result: osmose should warn about conflicting tags

Case 2: way without amenty= tag but part of multipolygon with amenity=kindergarten contains (way/multipolygon) building=school
Expected result: osmose should warn about conflicting tags

PS. This is not limited to (building|amenity)=(kindergarten|school|college|university) but just example how to handle mismatches.

Bad multiple number in street with other close street with same name in other city

item=2060, class=6
Bad multiple numbers in street with other close street with same name in other city.
Need check street name and city before report issue.

boundary_administrative : InternalError: GEOS intersects() threw an error!

depuis quelque jours, france_picardie : osmosis_boundary_administrative a l'erreur "InternalError: GEOS intersects() threw an error!"
http://jenkins.osmose.openstreetmap.fr/view/Fails/job/france_picardie/

j'ai corrigé les relations de 6 communes dont la geometrie était "invalide"
(trouvées avec ST_IsValid='f' )
critere a ajouter a "sql11" ?

bug with diet:vegetarian

http://osmose.openstreetmap.fr/de/error/2569778265
osmose wants to change

diet:vegetarian

to the wrong

dist:vegetarian=yes

Same with diet:vegan http://osmose.openstreetmap.fr/de/error/2569778266

Check for useless wikipedia:xy=*

wikipedia:xy=* may be useless if it's a trandlation of the main wikipedia tag wikipedia=yz:*
http://wiki.openstreetmap.org/wiki/Key:wikipedia

Detect wrong highway connections

I don't know what osmose already detects or if this is wanted, but could osmose detect:

1. highway connected to waterway|water without ford
2. highway connected to power=line|minor_line
3. highway connected to landuse

Broken highway continuity, part 2

Thank you for fixing #54. There's another issue with this detection that I cannot fathom.

Error: http://osmose.openstreetmap.fr/en/error/2787511794
Location: http://www.openstreetmap.org/#map=18/54.21516/21.73803
The way in fault: http://www.openstreetmap.org/way/174463054

What is wrong here? Connection is fine, can't see a problem. Can you fix it so there are no more false-positives like these?