Giter Site home page Giter Site logo

Comments (11)

frodrigo avatar frodrigo commented on June 10, 2024

Bonus points if this check will understand multi-language links (i.e. it will recognize fr:Canal de Suez and en:Suez Canal as same link).

This part is already present :
http://osmose.openstreetmap.fr/errors/?item=3031&class=30317

from osmose-backend.

frodrigo avatar frodrigo commented on June 10, 2024

Please, can you explain the main requested feature ?

from osmose-backend.

d1g avatar d1g commented on June 10, 2024

@frodrigo, I'm sorry for delayed answer. Take a look at http://www.openstreetmap.org/way/192205777/history and http://www.openstreetmap.org/way/135401603/history

and you will notice that exactly the same link wikipedia="ru:Ташкентский музей железнодорожной техники" was used at the same time. Usually this means that objects are duplicated or like in this case link was added twice due to editor mistake.

from osmose-backend.

d1g avatar d1g commented on June 10, 2024

ru:Ташкентский музей железнодорожной техники and uk:Ташкентський Музей залізничної технік should be treated as it was the same object

from osmose-backend.

frodrigo avatar frodrigo commented on June 10, 2024

Many parts of the same street: http://overpass-turbo.eu/?Q=way%5B%22wikiped an issue for you ?

Can point to list: http://overpass-turbo.eu/?Q=way%5B%22wikipedia%22%3D%22fr%3ACimeti%C3%A8re%20et%20m%C3%A9morial%20am%C3%A9ricain%20de%20la%20Somme%22%5D%3B%0A(._%3B%3E%3B)%3B%0Aout%3B&C=49.98592;3.22024;14&R

A brand: http://overpass-turbo.eu/?Q=way%5B%22wikipedia%22%3D%22fr%3ABurger%20King%22%5D%3B%0A(._%3B%3E%3B)%3B%0Aout%3B&C=49.06127;6.14548;8&R

SELECT
  array_agg(id),
  tags->'wikipedia'
FROM
  ways
WHERE
  tags != ''::hstore AND
  tags?'wikipedia'
GROUP BY
  tags->'wikipedia'
HAVING
  count(*) > 1
;

from osmose-backend.

d1g avatar d1g commented on June 10, 2024

parts of the street aren't interesting, duplicated POIs are (museums, memorial, etc)

brand:wikidata=* would be a better tag in second case

from osmose-backend.

frodrigo avatar frodrigo commented on June 10, 2024

I run the same on nodes/way/relation and add some filter on networks like road, rails... and other kind of brand networks. But I think there is still too many false positives.

Look on the actual output, can you suggestgest more filter to avoid false positives, please: http://sprunge.us/ZeFj

SELECT
  w,
  array_agg(tid)
FROM
(
(
SELECT
  tags->'wikipedia' AS w,
  'N' || id AS tid
FROM
  nodes
WHERE
  tags != ''::hstore AND
  tags?'wikipedia' AND
  NOT tags->'wikipedia' LIKE '%#%' AND
  NOT tags?| ARRAY['highway', 'railway', 'waterway', 'power', 'place', 'shop', 'network', 'operator']
) UNION (
SELECT
  tags->'wikipedia' AS w,
  'W' || id AS tid
FROM
  ways
WHERE
  tags != ''::hstore AND
  tags?'wikipedia' AND
  NOT tags->'wikipedia' LIKE '%#%' AND
  NOT tags?| ARRAY['highway', 'railway', 'waterway', 'power', 'place', 'shop', 'network', 'operator']
) UNION (
SELECT
  tags->'wikipedia' AS w,
  'R' || id AS tid
FROM
  relations
WHERE
  tags != ''::hstore AND
  tags?'wikipedia' AND
  NOT tags->'wikipedia' LIKE '%#%' AND
  NOT tags->'type' IN ('route', 'boundary') AND
  NOT tags?| ARRAY['highway', 'railway', 'waterway', 'power', 'place', 'shop', 'network', 'operator']
)
) AS t
GROUP BY
  w
HAVING
  count(*) > 1
;

from osmose-backend.

d1g avatar d1g commented on June 10, 2024

operator=* or relation:site were used in some places to group the same operator (a website and operator name should change in one place) each office can have it's own tel. tag

operator:wikipedia or operator:wikidata would be more accurate IMO

from osmose-backend.

frodrigo avatar frodrigo commented on June 10, 2024

For brands and operators I don't see what we should have ref to wikipedia. Company are abstract concept not directly linked to a place of one of his office. Maybe valid for the headquarter.

from osmose-backend.

d1g avatar d1g commented on June 10, 2024

Company are abstract concept not directly linked to a place

thats why we are not placing wikipedia links for every mcdonalds (we have under 150 values in wikipedia=* tag)

Only headquarter of MAIF should get a wikipedia=* tag.

from osmose-backend.

didier2020 avatar didier2020 commented on June 10, 2024

analyser_osmosis_wikipedia use item 1220 for waterway
see http://osmose.openstreetmap.fr/en/errors/?source=29115

from osmose-backend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.