ostis-ai/py-sc-client

Python implementation of client for communication with Websocket sc-server.

py-sc-client's Issues

Add error handling in a ScConstruction class

Describe the bug
If index by alias is not exist, error can be raised.

To Reproduce

Expected behavior
return None value

Additional context
Add error handling in a ScConstruction class, or use get() method for taking value from dict.

Problem in correct client completion

Problem with correct client completion in case of deal with non-existed node

To Reproduce
To reproduce can be execute next code for any non-existed identifier:
keynodes = ScKeynodes()
node = keynodes["hello"]

Expected behavior
Raises exception InvalidValueError and completes

Screenshots

Non-private constants in sc_client.constants.sc_types

Describe the bug
In sc_client.constants.sc_types there are integer constants that are not supposed to be imported. (e.g. SC_TYPE_NODE, SC_TYPE_LINK, etc.)

Proposal
Mark this constants as private to avoid common user from occasionally importing them.

Typing error in ScLinkContent

Typing error

Where: sc_client.models.py - ScLinkContent

Type of content_type in ScLinkContent is ScLinkContentType (not int), so why it's comparing by value in type_to_str()?

class ScLinkContentType(Enum):
    INT = 0
    FLOAT = 1
    STRING = 2
    BINARY = 3


@dataclass
class ScLinkContent:
    data: str | int
    content_type: ScLinkContentType
    addr: ScAddr = None

    def __post_init__(self):
        if len(str(self.data)) > LINK_CONTENT_MAX_SIZE:
            raise LinkContentOversizeError

    def type_to_str(self):
        if self.content_type == ScLinkContentType.BINARY.value:
            return common.BINARY
        if self.content_type == ScLinkContentType.INT.value:
            return common.INT
        if self.content_type == ScLinkContentType.FLOAT.value:
            return common.FLOAT
        return common.STRING