otezvikentiy/symfony-jsonrpc-api-bundle

Symfony Json RPC Bundle

symfony-jsonrpc-api-bundle's Issues

Fails without version?

    App\JsonRpcController\:
        resource: '../src/JsonRpcController/{*Method.php}'
        tags:
            - { name: ov.rpc.method, namespace: App\JsonRpcController\ }

<?php

declare(strict_types=1);

namespace App\JsonRpcController;

use App\Dto\EchoDto;
use OV\JsonRPCAPIBundle\Core\Annotation\JsonRPCAPI;

#[JsonRPCAPI(methodName: 'productEcho', type: 'POST')]
class JsonRpcProductEchoMethod
{
    public function call(EchoDto $dto): EchoDto
    {
        return $dto;
    }
}

{"jsonrpc":"2.0","error":{"code":0,"message":"App\\JsonRpcController\\JsonRpcProductEchoMethod::call(): Argument #1 ($dto) must be of type App\\Dto\\EchoDto, null given, called in \/vendor\/otezvikentiy\/json-rpc-api\/src\/Controller\/ApiController.php on line 133"},"id":"1"}

How to describe OpenAPI?

#[JsonRPCAPI(methodName: 'product.echo', type: 'POST')]
class JsonRpcProductEchoMethod
{
    public function call(EchoDto $dto): EchoDto
    {
        return $dto;
    }
}

produces unexpected echoRequest and echoMainRequest schemas

product.echoRequest:
    type: object
    properties: {  }
    required: {  }
product.echoMainRequest:
    type: object
    properties: { jsonrpc: { type: string, format: '', default: '2.0', example: '2.0' }, method: { type: string, format: '', default: product.echo, example: product.echo }, params: { $ref: '#/components/schemas/product.echoRequest' } }
    required: [jsonrpc, method, params]
EchoDtoResponse:
    type: object
    properties: { jsonrpc: { type: string, format: '', default: '2.0', example: '2.0' }, tenant: { type: string, format: '', default: '', example: '' }, product: { type: App\Dto\ProductDto, format: '', default: '', example: '' } }
    required: [jsonrpc, tenant, product]

Fails on v1?

    App\JsonRpcController\:
        resource: '../src/JsonRpcController/v1/{*Method.php}'
        tags:
            - { name: ov.rpc.method, namespace: App\JsonRpcController\v1\, version: 1 }

<?php

declare(strict_types=1);

namespace App\JsonRpcController\v1;

use App\Dto\EchoDto;
use OV\JsonRPCAPIBundle\Core\Annotation\JsonRPCAPI;

#[JsonRPCAPI(methodName: 'productEcho', type: 'POST')]
class JsonRpcProductEchoMethod
{
    public function call(EchoDto $dto): EchoDto
    {
        return $dto;
    }
}

Expected to find classApp\JsonRpcController\JsonRpcProductEchoMethod in file jsonrpc/src/JsonRpcController/v1/JsonRpcProductEchoMethod.php while importing services from resource ../src/JsonRpcController/v1/{*Method.php}, but it was not found!