otvam/pypeec

PyPEEC - 3D Quasi-Magnetostatic FFT-Accelerated PEEC Solver

Thomas Guillod - otvam

Hi, my name’s Thomas and I am a power electronics engineer and research scientist. I studied at ETH Zurich, Switzerland (Bachelor, Master, and Ph.D) with a focus on power electronics, medium-voltage systems, and numerical analysis. I am currently doing research on magnetic material modeling at the Thayer School of Engineering at Dartmouth College, USA. More specifically, my current research interests include high-frequency magnetic components, high-frequency power magnetic materials, and advanced modeling techniques.

• Website
• Linkedin Profile
• GitHub Profile
• Curriculum Vitae
• Google Scholar Profile
• Dartmouth College / PMIC
• Dartmouth College / Engineering

pypeec's Issues

[joss review] python requirements ?

[This is issue is part of the review of the paper submited to JOSS.]

First, I would recommend an INSTALL file at the root of the sources. On the first contact with the library, I didn't see any installation instructions and had to figure out that I had to use pip from the "Project links" section of the README.
The installation instructions are somehow hidden in the tutorial, which is is not so obvious. At least the INSTALL file could link to the tutorial, IMHO. Also the root of the directory contains file related to conda, which is not mentioned in the installation section.

Regarding first contact with pypeec, there are a few scripts called run... at the root of the sources which seems tools for developers. The prefix run seems misleading and users may be tempted to have a look at them. That is only an totally discardable advice, but maybe such scripts would be better in a dedicated subdirectory (something like tools for instance).

I followed your installation guide and it failed as follows:

(pypeec-env) $ python3 -m pip install pypeec
Collecting pypeec
  Could not find a version that satisfies the requirement pypeec (from versions: )
No matching distribution found for pypeec
(pypeec-env)$ python3 
Python 3.7.3 (default, Oct 11 2023, 09:51:27) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

I guess that my version of python is too old. Would you tell me some minimal requirements for pypeec ?

VTK package bug (win64)

The VTK win64 conda package is broken:
- Package can be installed and is working
- Package is not marked as "installed" for PyPi

VTK is aware of the problem:
conda-forge/vtk-feedstock#323

PyVista crash (during closing and/or screenshot)

PyPEEC is affected by the following PyVista issue pyvista/pyvistaqt#314.

The problem is that the attribute image does not always exist in pyvista/plotting/plotting.py.
A temporary workaround is to add self.render() before self.image is referenced.

Create better Conda / Venv

Currently, the Conda and Python environment only include the required dependencies.
The optional libraries (UMFPACK, FFTW, MKL/PARDISO, and CuPy) are not installed.
The same goes for Trame support for PyVista (used for Jupyter).

It would be nice to also include these libraries.

Handling internal walls when merging 3D meshes

When 3D meshes are merged (STL mesher and shape mesher), all the walls (even the internals) are kept.
This has an impact of the viewer (voxelization plot) but not on the generated voxel structure.

Ideally, the merged mesh should be simplified.

Rasterio NotGeoreferencedWarning

Rasterio trigger some "NotGeoreferencedWarning: Dataset has no geotransform, gcps, or rpcs. The identity matrix will be returned." for some shape. This warning is currently ignored. It is not clear which shapes are causing the problem.