Error in superscript ordinals

[AadityaNitin]

Error in superscript ordinals

[tusharnankani]

Thanks for opening the issue, Aaditya!

We need to modify this:

catchup/util/catchup-number.js

Lines 19 to 26 in 750d1d2

	function getSuffix(catchUpNumber) {
	const lastChar = catchUpNumber.slice(-1);
	if (lastChar === "1") return "st";
	else if (lastChar === "2") return "nd";
	else if (lastChar === "3") return "rd";
	else return "th";
	}

Easy fix: the error will only (hopefully) come for x11. Should be th instead of st.

Do you want to take this up and create a PR, @AadityaNitin?

[HarshKapadia2]

Easy fix: the error will only (hopefully) come for x11. Should be th instead of st.

Numbers x11, x12 and x13 are all affected. They all should end with th rather than st, nd and rd respectively.

Eg: The current behaviour for OTC CatchUp no. 313 is to output 313rd, but it should be 313th.

[HarshKapadia2]

Thank you so much for opening a PR, Tushar!

[tusharnankani]

Oh yes, I had a feeling I was missing something.

The error will only (hopefully) come for x11. Should be th instead of st.

So, now we just check if the second last number is 1. Should be fairly simple.