feat: A button to edit/make the summary better via PRs..

[ourtechcommunity]

feat: A button to edit/make the summary better via PRs..

[tusharnankani]

I definitely think it is a good idea to add enough context like MDN.

What do you think @OurTechCommunity/core?

[HarshKapadia2]

Yeah I think adding a section like MDN at the bottom is a nice idea!

@sushma1031 can you design something like MDN that you like? We can go ahead from there. Do post a screenshot!

[tusharnankani]

Sure.

Here is a layout you could follow:

Improve the content on this page?

[Edit the summary on GitHub](https://github.com/OurTechCommunity/catchup/blob/main/summary/sessions/130/content.adoc).
[Report the content issue](https://github.com/OurTechCommunity/catchup/issues/new?title=Improve%20%3Cnum%3E%20summary&body=Enter%20summary%20URL%20and%20changes%20to%20be%20made:).
[View the source on GitHub](https://github.com/OurTechCommunity/catchup/blob/main/summary/sessions/130/content.adoc).

Want to get more involved? [Learn how to contribute](https://github.com/OurTechCommunity/catchup/blob/main/CONTRIBUTING.md).

Renders like:

Improve the content on this page?

Edit the summary on GitHub.
Report the content issue.
View the source on GitHub.

Want to get more involved? Learn how to contribute.

[HarshKapadia2]

Do modify the links to include the correct CatchUp numbers, @sushma1031 !

Thank you for the example, Tushar!

[tusharnankani]

One second, just realized this is an issue.

@sushma1031, please feel free to open a PR.
The UI looks great :D

[tusharnankani]

I think we need to debate on the position of this section. It looks good at the bottom, but I think it should be above the quotes and below the note with the blue icon.

Yes, let's place the content above the horizontal rule above the quotes. Would look good hopefully!

We might get rid of that note, but that's another issue - we really need to restructure our summary page.

Right. Let's figure that out at #113

[sushma1031]

Following the same layout for the combined summary page:

Code:

[.improve-heading]
Want to improve the content of this page?

[.improve-buttons]
* link:https://github.com/OurTechCommunity/catchup/tree/main/summary/sessions[Edit these summaries on GitHub.^]
* link:https://github.com/OurTechCommunity/catchup/issues/new?title=Improve%20combined%20summary&body=Enter%20changes%20to%20be%20made[Report the content issue.^]
* link:https://github.com/OurTechCommunity/catchup/blob/main/summary/combined-summary-template.adoc[View the source on GitHub.^]


[.contribute]
Want to get more involved? link:https://github.com/OurTechCommunity/catchup/blob/main/CONTRIBUTING.md[Learn how to contribute.^]

[sushma1031]

I'd like to work on this.

I'd like to request some clarification:

1. Are there any specifications about the appearance of the button?
   1.1. In the Next.js example, it's just displayed as a link, is the same required here as well?
2. Should the button direct them to the GitHub repo, or something more specific?

[HarshKapadia2]

I'd like to work on this.

Awesome! Thank you!

I'd like to request some clarification:

1. Are there any specifications about the appearance of the button?
   1.1. In the Next.js example, it's just displayed as a link, is the same required here as well?

A link at the top of the page would be just fine!

2. Should the button direct them to the GitHub repo, or something more specific?

• For Individual summaries
  • The link should redirect to the summary directory pertaining to every CatchUp session (summary/sessions/<catchup_number>).
  • Example: The link on the 130th OTC CatchUp session summary page should redirect to https://github.com/OurTechCommunity/catchup/tree/main/summary/sessions/130.
  • Individual summary template: https://github.com/OurTechCommunity/catchup/blob/main/summary/individual-summary.adoc
  • Hosted individual 130th summary: https://catchup.ourtech.community/summary/130
• For the combined summary
  • The link should redirect to https://github.com/OurTechCommunity/catchup/tree/main/summary/sessions.
  • Combined summary template: https://github.com/OurTechCommunity/catchup/blob/main/summary/combined-summary-template.adoc
  • Hosted combined summary: https://catchup.ourtech.community/summary

Do let us know if you have any more questions! Also, do add pictures of how the pages look like, whenever you contribute!

Thank you!

[HarshKapadia2]

I think you're trying to add the link at the wrong place.

Try adding link:https://github.com/OurTechCommunity/catchup/tree/main/summary/sessions/130[Edit this summary on GitHub^] above line no. 17 of the individual-summary.adoc file:

catchup/summary/individual-summary.adoc

Line 17 in 7253154

'''

[sushma1031]

I gave that a try, this is the result:

If this is the required result, please let me know, I'll do the same for the combined summary as well

[HarshKapadia2]

@sushma1031 can you please try reducing the font size and send a screenshot of that?

Feel free to send pictures with any other looks that you think work better as well.

Cc: @tusharnankani

[sushma1031]

Will do!

[sushma1031]

I personally found the extra space at the top unappealing:

Hence I tried to make it even using css relative position

Let me know your thoughts

[tusharnankani]

Hey

Looks good, yeah.

Should we reduce the font size of the 'edit' link, @tusharnankani?

Yes.

Also, what do you think if we push the button to the bottom?

Something like this at MDN: https://developer.mozilla.org/en-US/docs/Web/javascript

[tusharnankani]

Let us know if you need any help!

[sushma1031]

I'll work on it.
I'd like to request some more information, such as what we want to include in this section, in addition to the edit summary link.

[sushma1031]

I'll make sure to include the respective numbers @HarshKapadia2.
Thank you for the layout @tusharnankani !

[sushma1031]

Here's how it looks now:

Here's my code:

[.improve-heading]
Want to improve the content of this page?

[.improve-buttons]
* link:https://github.com/OurTechCommunity/catchup/tree/main/summary/sessions/{catchup_display_number}[Edit this summary on GitHub.^]
* link:https://github.com/OurTechCommunity/catchup/issues/new?title=Improve%20%3C{catchup_display_number}%3E%20summary&body=Enter%20summary%20URL%20and%20changes%20to%20be%20made[Report the content issue.^]
* link:https://github.com/OurTechCommunity/catchup/blob/main/summary/sessions/{catchup_display_number}/content.adoc[View the source on GitHub.^]


[.contribute] 
Want to get more involved? link:https://github.com/OurTechCommunity/catchup/blob/main/CONTRIBUTING.md[Learn how to contribute.^]

Let me know if any changes are required.

Also, my CSS changes are being ignored by Git, as the summary-style.css is present in the .gitignore file. Could you please let me know what I should do?

[HarshKapadia2]

Here's how it looks now:

I like how this looks! What do y'all think @OurTechCommunity/core?

I think we need to debate on the position of this section. It looks good at the bottom, but I think it should be above the quotes and below the note with the blue icon. (Picture below.) (We might get rid of that note, but that's another issue - we really need to restructure our summary page.)

Also, my CSS changes are being ignored by Git, as the summary-style.css is present in the .gitignore file. Could you please let me know what I should do?

Summary styles are located in https://github.com/OurTechCommunity/catchup/blob/main/summary/static/css/summary-style.css, so please make your changes in that file. (I think the file that you're referring to is the file that is copied over to public/css/summary while building the site.)

[sushma1031]

Summary styles are located in https://github.com/OurTechCommunity/catchup/blob/main/summary/static/css/summary-style.css, so please make your changes in that file. (I think the file that you're referring to is the file that is copied over to public/css/summary while building the site.)

I was trying to update the wrong file as you pointed out. Thanks for directing me to the right one!

[sushma1031]

This is how it looks:

I was wondering if I should change the colour of "Want to improve the content..." to match these sub-headings:

[HarshKapadia2]

I was wondering if I should change the colour of "Want to improve the content..." to match these sub-headings:

No, let's keep the normal black text for now.

[HarshKapadia2]

Good idea, @dheerajdlalwani!

Some options for the button text:

• Suggest changes
• Edit summary on GitHub

[sushma1031]

I'm having trouble adding a link at the top of the page. This is my code for a test link:

= OTC CatchUp #{catchup_display_number} Summary
Our Tech Community
v1
:revremark: link:https://catchup.ourtech.community[Test Link^]

This is how it renders:

Could you please suggest the appropriate syntax?

Alternatively, I could add the link at the bottom:

[HarshKapadia2]

Should we reduce the font size of the 'edit' link, @tusharnankani?

[sushma1031]

Reducing the font size to 1rem appears like this:

Code:

[.edit-summary-btn]
link:https://github.com/OurTechCommunity/catchup/tree/main/summary/sessions/{catchup_display_number}[Edit this summary on GitHub^]

CSS

.edit-summary-btn a{
	font-size: 1rem;
}

[sushma1031]

Applying 0.75 rem made it look too small according to me, however let me know your opinion:

[sushma1031]

Sure @tusharnankani , I can try that. It would look similar to this, although here I haven't reduced the font size yet:

Alternatively, I could add the link at the bottom:

Also, should I add a message above the link, like in the MDN docs, or is just the link sufficient?

cc: @HarshKapadia2