ourzora/nouns-protocol

⌐◨-◨

nouns-protocol's Issues

Determine why metadata tests are failing when on github actions but work on local mac dev

Run forge test -vvv with no skips and it seems to work locally on osx but fail remote on linux?.

The contract addresses that are deployed in the tests are different which makes the strings generated in the metadata not match.

[Bug] There is a bug in MetadataRenderer.sol in the _generateSeed function

There is a bug in MetadataRenderer.sol in the _generateSeed function which impacts psuedo-randomness:

nouns-protocol/src/token/metadata/MetadataRenderer.sol

Line 330 in 82e00ed

return uint256(keccak256(abi.encode(_tokenId, blockhash(block.number), block.coinbase, block.timestamp)));

blockhash(block.number) will always return0x0000000000000000000000000000000000000000000000000000000000000000, since the hash of the current block cannot be known when the transaction is being executed.

Instead, blockhash(block.number - 1) should be used.

Index and show my DAOs when I'm only delegated tokens

• index delegated tokens in the subgraph
• show DAOs in my DAOs when I've been delegated tokens

Add a stream proposal type

• Allow a proposal to use treasury funds to create a sablier (or superfluid) stream

Add the ability to allow a delegator to cast a vote for a specific address

Currently, in Governor.sol the _castVote function takes in the following:

function _castVote(
    bytes32 _proposalId,
    address _voter,
    uint256 _support,
    string memory _reason
) internal returns (uint256)

This covers:

1.) A user who doesn't have a token (reverts)
2.) A user who has a token
3.) A user who is delegated tokens

however: what if a delegated voter (ex. an autonomous agent) wanted to make a vote only for a specific token holder? This doesn't cover that case.

It would be good IMO to add another param that is used to get the votes originally belonging to someone. So say Tom delegated 5 votes to an AI agent, and Sally also gave 5 votes, the ai can vote separately for each person. There would also have to be a check to make sure that the given address has delegated to the voter (ai agent)

In the case the param is 0x000... do the same logic that we have now.

Let me know if there are any questions, or if there are better approaches to this. Really excited about everything Nouns and would love to do this!

If you have no bid increment and reserve price of 0 no bids can be placed

If you have no bid increment and reserve price of 0 no bids can be placed

Seems unlikely in practice.

Should we remove the metadata renderer folder for now?

Add proposal IPFS uri field

To use for storing metdata

image
description

Export "holders" including delegated tokens

Provide an option to export the current set of delegated addresses. Usually, when we get token holders this is the actual set we want. Etherscan and others provide a naive balance of tokens.

• Probably relies on #130