outbrain/outbrain-ios-framework

outbrain-ios-framework's Issues

Outbrain has UIWebView in the binary

I am getting the UIWebView error from the appstore. While grepping I have seen this framework has the UIWebView. Any updates on this.

If I use the latest does it has any major changes for this in the implementation code?

Binary file project/Classes/OutbrainSDK.framework/OutbrainSDK matches

OutbrainSDK 4.0.1 not found

Hi,

getting a not found message even after repo update.

If I skip version in Podfile I get 3.9.3

SFCollectionViewManager orientation crash

Firebase reports that occasionally the SFCollectionViewManager will crash on orientation change.

In our implementation orientation changes are only allowed on iPad. The crash happens rarely; perhaps less than 0.1% of our users are confronted by it and I can't readily reproduce.

The following crash is logged in Firebase:

Fatal Exception: NSInternalInconsistencyException
attempt to delete item 9 from section 0 which only contains 0 items before the update
__46-[SFCollectionViewManager orientationChanged:]_block_invoke
keyboard_arrow_down

Fatal Exception: NSInternalInconsistencyException
0 CoreFoundation 0x1aea91298 __exceptionPreprocess
1 libobjc.A.dylib 0x1c27eb480 objc_exception_throw
2 CoreFoundation 0x1ae99ecc8 -[CFPrefsSearchListSource addManagedSourceForIdentifier:user:]
3 Foundation 0x1afcd6128 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:]
4 UIKitCore 0x1b0ac8c7c -[UICollectionView _endItemAnimationsWithInvalidationContext:tentativelyForReordering:animator:collectionViewAnimator:]
5 UIKitCore 0x1b0ac7598 -[UICollectionView _updateRowsAtIndexPaths:updateAction:updates:]
6 UIKitCore 0x1b0ac771c -[UICollectionView reloadItemsAtIndexPaths:]
7 OutbrainSDK 0x101150aec __46-[SFCollectionViewManager orientationChanged:]_block_invoke + 156 (SFCollectionViewManager.m:156)
8 libdispatch.dylib 0x1ae6c9298 _dispatch_client_callout
9 libdispatch.dylib 0x1ae66e028 _dispatch_continuation_pop$VARIANT$mp
10 libdispatch.dylib 0x1ae67ed64 _dispatch_source_invoke$VARIANT$mp
11 libdispatch.dylib 0x1ae677bc4 _dispatch_main_queue_callback_4CF$VARIANT$mp
12 CoreFoundation 0x1aea102e0 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE
13 CoreFoundation 0x1aea0a740 __CFRunLoopRun
14 CoreFoundation 0x1aea09818 CFRunLoopRunSpecific
15 GraphicsServices 0x1c510f570 GSEventRunModal
16 UIKitCore 0x1b13350e8 -[UIApplication _run]
17 UIKitCore 0x1b133a664 UIApplicationMain
18 Brabant 0x1008b29f8 main + 16 (AppDelegate.swift:16)
19 libdyld.dylib 0x1ae6e8140 start

Privacy Manifest

Hi there,

As of May 1st 2024, Apple requires third-party SDKs to add a Privacy Manifest file.
https://developer.apple.com/support/third-party-SDK-requirements/
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files

Are there plans to include a Privacy Manifest?

(we currently use OutbrainSDK v 4.29.0 and our deployment target is limited to iOS 12.0)

Outbrain SDK xcframework

for the SDK Outbrain provided including multi architecture which is easy to develop but if manually import sdk when distribute will cause code signing issue.

even though we can use script get through it
suggest either provide xcframework format or split architecture distribute the SDK.

Issue When Integrating Outbrain SFWidget Bridge in UITableView - No Delegate Callback, No Network Request, No Logging

Hello,

I integrated the Outbrain SDK and switched from the legacy Smartfeed SDK to the SFWidget SDK, as described here.

Unfortunately the Widget remains Blank, I doulbe checked all the Logs and Code, but the Widget does not get initialized.

I configured the Widget with:

    [Outbrain initializeOutbrainWithPartnerKey:@"xxxxxx"];
    [self.sfWidget configureWithDelegate:self url:self.articleURL widgetId:@"MB_1" installationKey:@"xxxxxx"];

And I placed the Outbrain-Widget in the Middle of a TableView - I created a new Section with one Row, but nothing Happens.

[Outbrain SDKInitialized] returns true

[self.sfWidget getCurrentHeight] always returns 0, if I return 200 (for test purposes) I get an empty Widget

No SFWidgetDelegate method is called.

I also verified with Charles Remote Proxy if any network request is sent from Outbrain, but there's nothing what is sended.

I implemented this methods:

[self.sfWidget scrollViewDidScroll:scrollView];
[self.sfWidget willDisplaySFWidgetTableCell:(SFWidgetTableCell*)cell];

Can you help me? Am I missing a call?

We're using Version 4.21.0 of the Outbrain-Widget.