Comments (15)
@jancborchardt if we are moving in the DAV direction, I would also like you to give a direction to both contacts and calendar.
from contacts.
I would also vote for option 2. I like the split view a lot and many desktop apps like Gnome Contacts look similar.
from contacts.
Option 2 sounds good, but we should probably move the code for the split view to core.
from contacts.
@Henni yep, definitely as soon as at least 2 apps use it we should move it into core. Let’s take what we use in the Mail app and apply it for the Contacts rework, and as soon as it all works for both apps we can move it to core.
from contacts.
I think too that the 2nd options is better, especially if another owncloud app uses this layout, I like consistency in different parts of the same system.
from contacts.
@babelouest cool! It would be great if you’re in for collaborating on this app as well, as we aim to make it the main Contacts app. Hopefully with 9.0 as CardDAV should be moved into core by then. See owncloud/core#20184 (and maybe help to review :)
from contacts.
Option 2 would also be my choice.
from contacts.
@marneu yeah, we’re working on that in https://github.com/Henni/contactsrework/tree/contactlist-design (branch contactlist-design
) – any help welcome.
from contacts.
@marneu just saw you’re based in Munich: Come join us at our next ownCloud meetup: http://www.meetup.com/owncloud-munich – @Henni, @DeepDiver1975, me and more are always there to hack on apps.
from contacts.
@jancborchardt: see you there ;)
from contacts.
@marneu cool! Bring your laptop and ideally already look into the code beforehand. :)
from contacts.
@jancborchardt: laptop ok, code noop (helping on a different project in the moment). Coming as tourist for future tasks on oc. Maybe as helper on less time consumptive ops for the moment. ;)
from contacts.
@marneu cool! Yeah, just keep in mind it’s a hands-on meetup, no presentations or anything like that. :)
from contacts.
@jancborchardt: Is ok, just give me time for snooping around - then we will see ;)
Just reminders for me,myself and my for vCards and the data entry part:
vCard export should have an etag within header not only within vcard (ref https://tools.ietf.org/html/rfc6352#section-6.3.2.3). Today it is a getlastmodified for the whole addressbook which could remain and be extended with an additional xml element cs:getctag based on last changed in total (further ref: "Retrieving calendar information":http://sabre.io/dav/building-a-caldav-client/) and finally one(!) "VERSION: 3.0" is enough .
Allow "star" mark the preferred phone entry (TEL), email (EMAIL), address (ADR) etc. (ref. "5.2 PREF":https://tools.ietf.org/html/rfc6350
Allow more types/combinations like examples: "work,fax", "home,fax", "work,cell", "home,cell", "holiday,cell" and even own tags like "mytext" or "mytext,home".
Bring in a new field item: _item(N).URL and item(N).X-AB-ABLabel or item(N).X-ABRELATEDNAMES, for further relations, like: "mytext" => "don't call dad past 22:00" or "Sister" => "another Ref"
Full working example from gcontacts:
BEGIN:VCARD
VERSION:3.0
FN:Dr. med. Max Mustermann
N:Mustermann;Max;;Dr. med.;
EMAIL;TYPE=INTERNET;TYPE=WORK:[email protected]
TEL;TYPE=WORK:+49 89 1234567
TEL;TYPE=WORK;TYPE=FAX:+49 89 987654
ADR;TYPE=WORK:;;Münchner Str. 48;Anywhere;;80000;
TITLE:Facharzt für Something
item1.URL:www.arzt-something.de
item1.X-ABLabel:_$!<HomePage>!$_
item2.X-ABRELATEDNAMES:Erne Musterfrau
item2.X-ABLabel:Hausarzt
NOTE:Sprechstunden\:\nMo.\, Di.\, Do. 8\:00 Uhr bis 13\:00
Uhr\nMi. und Fr. 8\:00 Uhr bis 12\:00 Uhr nach Vereinbarung\n
END:VCARD
Accept vCard import the same way like export.
Avoid : display in notes it should be : instead.
from contacts.
Closing because we solved it. Please help testing the Contacts app now!
from contacts.
Related Issues (20)
- Sort by Organization HOT 1
- Cannot select the addressbook where to import. HOT 3
- Include better error reporting on contact import
- Valid timestamp in vcard HOT 3
- JS tests failing in CI HOT 4
- Feature request: api or other ways to connect to contact from outside ? HOT 3
- javascript tests failing in CI HOT 1
- js-tests failing in drone CI HOT 1
- HTTP error code 412 when trying to add/update a contact HOT 3
- Adding a field doesn't "stick" across logins
- Javascript tests are failing in CI HOT 4
- Release contacts 1.5.6 HOT 6
- Nightly CI JS test coverage not found HOT 1
- JS tests fail often in CI HOT 1
- [QA] white text on light green background is hard to read
- [QA] notes input field can be dragged "underneath" items in second column
- [QA] Upload button silently does nothing
- JavaScript tests are not running in drone CI HOT 1
- javascript-tests pipeline is failing and needs further investigation HOT 13
- Failure in `phpstan-php7.4` `install-app-php-contacts` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contacts.