owncloud/contacts

:busts_in_silhouette: Manage your CardDAV contacts from a feature-rich web-interface

ownCloud Contacts

A contacts app for ownCloud

This is the new contacts app that has replaced the old contacts app, and is only the frontend for the new server-integrated CardDAV-Backend.

Maintainers:

• Thomas Müller
• Hendrik Leppelsack
• Jan-Christoph Borchardt
• Tom Needham

If you’d like to join, just go through the issue list and fix some. :)

Building the app

The app can be built by using the provided Makefile by running:

make

This requires the following things to be present:

• make
• which
• tar: for building the archive
• curl: used if phpunit and composer are not installed to fetch them from the web
• npm: for building and testing everything JS

Publish to App Store

First get an account for the App Store then run:

make && make appstore

The archive is located in build/artifacts/appstore and can then be uploaded to the App Store.

Running tests

You can use the provided Makefile to run all tests by using:

make test

This will run the PHP unit and integration tests and if a package.json is present in the js/ folder will execute npm run test

Of course you can also install PHPUnit and use the configurations directly:

phpunit -c phpunit.xml

or:

phpunit -c phpunit.integration.xml

for integration tests

contacts's Issues

Utilize new dav endpoint in core

Test the new Contacts app and contribute!

We are working on the Contacts rework for 9.0: https://github.com/owncloud/contactsrework
The CardDAV syncing was moved into core, and this is the repo for the new Contacts app frontend.

I’m using this issue to cc everyone who worked on Contacts in the past:
@babelouest, @jbtbnl, @ockham, @derkostka, @jakobsack, @schuemann, @tribut, @mroi, @lupusmeatus, @BernhardPosselt, @AdamWill, @LEDfan, @vgezer, @rehrumesh, @DavidPrevot, @martin-rueegg
You can easily help in several ways:

• test everything and open issues!
• have a look at issues and contribute (or ask developer friends to help): https://github.com/owncloud/contactsrework/issues
• review pull requests https://github.com/owncloud/contactsrework/pulls
• join the #owncloud-contacts IRC channel

Thanks a lot! :)

Import / Export of contacts

This was in the previous version. What happened to that? Very useful and user friendly.

Support text based birthdays

RFC 6350 allows vCards entries like BDAY;VALUE=text:circa 1800 which should be supported as well as date birthdays

Order of detail items

Currently the fields are ordered alphabetically in the dropdown, and by i-have-no-idea in the details view.

The order should be like this in both the details view and dropdown (bold items are shown by default):

• Organization & title (should be combined

^ we could put that in the header as well, smaller below the name

• Phone
• Email
• Address
• Instant messaging

^ that’s all the contact stuff, which can have home/work/other dropdowns.

• Nickname
• Birthday
• Website
• Notes
• Groups
• Role (let’s remove it …)

^ not entirely set on the order of the stuff in this last part.

Contacts not showing up after refresh

How to reproduce:

• Click 'Add contact'
• Refresh the page

Expected Result:

• Contact showing up

Actual Result:

• Not a single contact showing up

---

The PROPFIND request returns the correct list of contacts,
but it seems like they are not handled and shown afterwards.

Integrate Search

Addressbook share icon doesnt show in Firefox or safari

Hover over an addressbook in firefox of safari and the sharing icon does not appear. Similar issue appeared in Calendar-rework so need to look at how it got fixed. I had a suspicion that it was related to adblockers removing it - not sure if there is any merit in this

[Feature Request] Telephone book offload link for voip phones

I've tried a description already in https://github.com/owncloud/contacts/wiki/Integration-for-the-voip-phone-addressbook

Just a crosslink: https://github.com/owncloud/contacts/issues/1113

Show favorite contacts first in list

Instead of having a separate group/section for favorite contacts, they should always be shown first in the list.

In the future we can even sort them by frequency of contact through the Mail app. ;)

Propfind props for groups

»This app has no maximum ownCloud version assigned. This will be an error in ownCloud 11 and later.«

@Henni what’s the maximum ownCloud version?

@DeepDiver1975 What’s the best practice for setting this? Setting to current dev version, which is 9.0?

»No contacts« placeholder should not show until everything is loaded

Currently the »No contacts« placeholder shows first, which is quite confusing and leads one to think of data loss. Instead we should display a spinner for feedback. Only when there really is no contact, show that message.

remove emtpy group

as soon as the last contacts is deleted from one group we should remove the group from the group list

README.md - Redesign

Hi there,

I think we should redesign the README.md of the contacts app as @georgehrke described for calendar-rework in owncloud/calendar#159 ;)

I have already done this task for the ownCloud core's README.md and I am planning to do this for contacts in the next days ;)

It will be based on my guidelines i published here: https://github.com/owncloud/core/wiki/README.md-Guidelines

Cannot log-in after enabling the App

Maybe something is missing, but i cannot get into my owncloud after enabling the contactsrework.

a) Do i have to disable the "deprecated" contacts app ?
b) Do i need to rename this new app to "contacts" ?

Log is:
{"reqId":"4vhxURWv5wF2+UtkmEqB","remoteAddr":"192.168.6.1","app":"index","message":"Exception: {"Exception":"RuntimeException","Message":"image not found: image:app.svg webroot: serverroot:\/var\/www\/owncloud","Code":0,"Trace":"#0 \/var\/www\/owncloud\/apps\/contactsrework-master\/appinfo\/app.php(35): OC\URLGenerator->imagePath('contactsrework', 'app.svg')\n#1 \/var\/www\/owncloud\/lib\/private\/navigationmanager.php(63): OC_App::OCA\ContactsRework\AppInfo\{closure}()\n#2 \/var\/www\/owncloud\/lib\/private\/app.php(645): OC\NavigationManager->getAll()\n#3 \/var\/www\/owncloud\/lib\/private\/templatelayout.php(82): OC_App::getNavigation()\n#4 \/var\/www\/owncloud\/lib\/private\/template.php(225): OC\TemplateLayout->__construct('user', 'files')\n#5 \/var\/www\/owncloud\/lib\/public\/appframework\/http\/templateresponse.php(156): OC_Template->fetchPage()\n#6 \/var\/www\/owncloud\/lib\/private\/appframework\/http\/dispatcher.php(112): OCP\AppFramework\Http\TemplateResponse->render()\n#7 \/var\/www\/owncloud\/lib\/private\/appframework\/app.php(110): OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\Files\Controller\ViewController), 'index')\n#8 \/var\/www\/owncloud\/lib\/private\/appframework\/routing\/routeactionhandler.php(45): OC\AppFramework\App::main('OCA\\Files\\Contr...', 'index', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)\n#9 [internal function]: OC\AppFramework\routing\RouteActionHandler->__invoke(Array)\n#10 \/var\/www\/owncloud\/lib\/private\/route\/router.php(273): call_user_func(Object(OC\AppFramework\routing\RouteActionHandler), Array)\n#11 \/var\/www\/owncloud\/lib\/base.php(856): OC\Route\Router->match('\/apps\/files\/')\n#12 \/var\/www\/owncloud\/index.php(39): OC::handleRequest()\n#13 {main}","File":"\/var\/www\/owncloud\/lib\/private\/urlgenerator.php","Line":190}","level":3,"time":"February 17, 2016 21:10:30","method":"GET","url":"/apps/files/"}

Adding new field which already exists results in existing field being emptied

Instead of the field being emptied, there are 2 cases:

• If the field can only exist once (like »Organization« or »Nickname« or »Notes«) the entry should be removed from the »Add new field« dropdown as soon as the field already exists
• If there can be multiple fields (like telephone, address, email), there should of course be another one added.

Not sure how much of this is possible til release, but for sure we shouldn’t clear any data. As a quick fix, only focus the already existing field.

Contact birthdays

Is it planned to offer a CalDAV link for all contacts birthdays?

I'm not sure whether this should be addressed by the new contacts app or the new calendar app.

Using datepicker causes crash

Use the datepicker, as soon as you pick a date the JS console spits out something like this:

TypeError: value.value.map is not a function

(Long error, best test for yourself)

And after that, no fields can be added or deleted until refresh.

Make Organization and Title a group

Similar to the address fields, the fields for »Organization« and »Title« belong together and should be made a group. Title should always appear below the Organization field. That’s also how Android and others do it.

Visually, we could then also add some whitespace above and below that group similarly to how we do with the address.

Only show delete icon on hover of that respective row, or when the corresponding field is focused

Currently it is very busy due to the icons, and that would help a lot. The icon even showing when the field is focused also ensures it will work with touch devices.

Consider signing the application

You might want to consider signing the application when uploading to the appstore. Uploaded release balls on GitHub can everybody modify 🙈 🙊 🙉

It would be an additional step before TAR'ing, see https://doc.owncloud.org/server/9.0/developer_manual/app/code_signing.html#how-to-get-your-app-signed on how to request a certificate.

Adding new contact should open that contact and insert it first in the list

Currenty a Contact »Max Mustermann« is just inserted in the middle of the list.

Instead, this should happen:

• insert a contact »New contact« first item in the list of contacts
• automatically open up that contact with focus on the Name field (I’m adding a placeholder text in a design PR)

Rename »URL« to »Website«

URL is much too technical, it should be called »Website«.

Mobile styles

We need to copy over the mobile styles from the Mail app so contacts properly works on small screens.

detailsitems need class of type of field so they can be identified

For styling the address fields for example, I need the detailsitem elements to have a class. For example for the address detailsitem, give it a class="address" or whatnot. Otherwise I can’t specifically style it. cc @Henni @DeepDiver1975

Show first contact by default

The content-detail view should always display a contact. On start, simply the first one in the list.

Deleting a contact should close the detail view of that contact

Currently that stays open, which is kind of weird.

The contact gets deleted in the list, so the detail view of the next contact (lower down) should then be opened. When it was the last contact, the next one up.

Favorites

Will favorites work for 9.0? Will it be a read-only indicator maybe? Or not at all?

Either way, if we don’t finish that, we should hide the star in the contact list and then move the avatar a tad down for visual balance.

Handle not existing .well-known gracefully

I'm running owncloud with the php integrated web server and .htaccess is not supported.
As a result .well-known is not know - this results in fatal error

Only show url-link arrow element for website when an actual value was put in

Otherwise it makes no sense to show the linking arrow as it has no function.

Do not use .well-known/carddav url

For me there is a 404 request to the .well-known/carddav url in the network log:
http://localhost/.well-known/carddav

Use Contacts as CardDAV Client for non-ownCloud CardDAV Servers

Empty fields don't get removed

When creating additional fields (nickname, categories, etc.),
empty ones don't get deleted.
Whenever an additional field is empty,
the property should be removed.

Multiple fields introduced by #82
@DeepDiver1975

After adding a field, the »Add field« select should switch back to »Add field«

Currently the select label stays at the field which was last added, which is a bit confusing. Should switch back to the default »Add field« state.

Replace labels with icons

Since we are using placeholders on the fields now and the labels make the whole thing a bit busy I was thinking of replacing them with icons. E.g. marker icon for address, mail icon for email, etc. Most of them already exist so it would be quite simple.

What do you think @Henni @DeepDiver1975?

Add custom favicon

Note to self, we should have a nice custom favicon with the app icon (including .ico file cause otherwise it will not show up).

Highlight currently open contact in list (also groups in sidebar)

The currently open contact should get a class active added to its app-content-list-item in the list of people for proper highlighting.

Allow user to add federated cloud id to contact

I just tried the new contacts app and first let me say that it looks already really good! :-)

The old contacts app allowed the user to add th federated cloud ID to a contact.

The cloud id was stored this way in the vcard:

CLOUD;TYPE=HOME:[email protected]

It supported the same types as the email field so that a user could have multiple federated cloud IDs, e.g one personal ID and one work ID.

The share dialog also searches the address book for users with a cloud id, so this is quite useful to share with people from your address book. Would be great if this field would also exist in the new contacts app.

URL design

• for a contact open in »All« (or a contact with no group): #/contact-id
• when a group is open without any specific contact you clicked (meaning the first is loaded): #/group-id
• for when a group and contact is open: #/group-id/contact-id

We need to make sure the highlights are correctly set then too: #38

Default select state (Home, Work, etc) when adding new address or phone number

Currently it’s an empty select, which looks really weird. And can it even be empty?

It should be the first entry (Private) by default. If one already exists with private, use the next one (Work). And so on. This is how Android does it as well.

Also add select for Email, Website and IM?

They should also have the Private / Work etc dropdown, no?

Navigating to a non existing group leads to error in browser console

Can you release Alpha/Beta versions?

I wonder if you could release Alpha/Beta versions so that I can integrate them in the same way I do with the calendar app on the VMs.

This is useful for testing purposes.

Remove colons (:) after field labels

Because they are not necessary.

Whole row should be clickable

Instead of only the name / first line, the whole app-content-list-item row should be clickable to open the contact.

Layout

Since we’re now reworking the whole architecture based on the movement of dav into core, it’s a good point to revisit the design as well. Generally we should continue where we left off with the design of the current Contacts app because we put a lot of thought and work into it. cc @babelouest @jbtbnl

• app-sidebar is for displaying groups, adding and editing them
• app-content is for showing the actual contact list and showing/editing the details
• addressbooks go into the settings area because the majority only has one addressbook (also similar as we do for mail accounts in the Mail app)

The main question here is how we do the display of the contact list and the details. There are a few options:

1. Do it like in the current Contacts app, with the row expanding to reveal the full details.
2. Do it similar to the Mail app with a split content view, left column has the list of the contacts, and right area has the details. (We could use the sidebar for core from that, but it would be kind of a hack since then we would need to make sure it always is displayed, has a wider width, and it would conflict with sharing contacts, groups or address books since that’s what the sidebar is for.)
3. Use a completely new layout like bigger avatars and several columns. Similar to Facebook friends view on one’s profile. But then we still need a way to display and edit the details.
4. … ?

I’d say best is number 2. What do you think @MorrisJobke @raghunayyar @DeepDiver1975 @Henni @irgendwie @ChristophWurst @schiesbn @jbtbnl @babelouest?

Creation of multiple fields for Organization and Nickname possible

This should not be possible, right? Fields like organization and nickname should only exist once I assume?

hardcoded apps path ....

apps cannot be hardcoded when loading the template since an app can be installed in another folder

When adding a new contact, insert some detailItems by default

Currently there’s only an empty view with the name input and you need to add fields by yourself.

Instead, these common fields should be pre-inserted, in that order:

• Phone
• Email
• Address