ownzones/mpegts

A C++ library for multiplexing and de-multiplexing MPEG-TS

mpegts's Issues

demuxer is sensitive to buffer size

i.e. I guess usually one will read chunks from a file in some arbtrary size (4k page size for example) and feed that to the demuxer. but the demuxer rarely checks wether the buffer is exhausted and thus depends on either some magic block size or the whole file being fed at once. this can be easily verified by replacing UnitTest1::muxOutput with

void UnitTest1::muxOutput(SimpleBuffer &rTsOutBuffer) {
    //Double to fail at non integer data
    double packets = (double) rTsOutBuffer.size() / 188.0;
    if (packets != (int) packets) {
        std::cout << "Payload not X * 188 " << std::endl;
        mUnitTestStatus = false;
    }

    uint8_t* lpData = rTsOutBuffer.data();

    for (int lI = 0 ; lI < packets ; lI++) {
        auto p = lpData+(lI*188);
        SimpleBuffer lIn;
        lIn.append(p, 100);
        mDemuxer.decode(lIn);
        lIn.clear();
        lIn.append(p + 100, 88);
        mDemuxer.decode(lIn);
    }
}

which feeds the demuxer the same data, but in smaller chunks, which makes the test fail miserably.

Windows build

While Windows may not be a target, during my attempt to build I've run into two issues:

• This a variable doing nothing seems to be disliked by msvc here https://github.com/Unit-X/mpegts/blob/master/mpegts/mpegts_muxer.cpp#L237
• Trouble with any when using MpegTsDemuxer as a shared pointer (this could be my issue, not sure)

[ERROR] OUTPUT>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.26.28801\include\any(429): error C2338: any_cast<T>(any&&) requires T to be constructible from remove_cv_t<remove_reference_t<T>>
[INFO] OUTPUT>c++/TSHandler.cpp(384): note: see reference to function template instantiation '_Ty &std::any_cast<std::shared_ptr<MpegTsDemuxer>&>(std::any &&)' being compiled
[INFO] OUTPUT>        with
[INFO] OUTPUT>        [
[INFO] OUTPUT>            _Ty=std::shared_ptr<MpegTsDemuxer> &
[INFO] OUTPUT>        ]