panic: label value "/\xff.js" is not valid UTF-8

[oxyno-zeta]

panic: label value "/\xff.js" is not valid UTF-8

[oxyno-zeta]

Hello !

First of all, thanks for your issue.

The problem isn't coming from the s3-proxy product itself but from the prometheus golang client. In fact, Prometheus doesn't support non UTF-8 strings as described in this issue 805.
According to this issue, it is better to have everything in utf-8.

Can you tell me more info about the context of the request ? Can you provide me an example with cURL or something like that ?

[alexdulin]

Without verifying, I am pretty sure you could send a curl request with any non-utf8 characters in the request path and trigger this issue. The prometheus client is, understandably, rejecting the lables for a variety of reasons as outlined in that issue. The problem with the panic is not an issue with the request really, its due to using unsanitized user input for a metric label. If request paths are going to be used as labels, then they should be sanitized. Same reason you sanitize data that is going to be inserted into a SQL database.

Unrelated to the issue, but thank you for making this project. It is a fantastic peice of work that solves so many common problems.

[oxyno-zeta]

I'm sorry but I can't reproduce this case with cURL. When I try to request this kind of path: "/traÖção" with cURL, the server got: "/tra%C3%96%C3%A7%C3%A3o" which is a perfect url encoded string and in UTF-8...

Can you give me an example with something that I can start ? Thanks !

PS: Thanks for your comment. I'm happy to see that this project is used. Don't forget to put a star :)

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days