p-janik/react-native-launch-darkly

React native wrapper for native Launch Darkly SDKs

react-native-launch-darkly's Issues

Remove override of createJSModules in RNLaunchDarklyPackage.java

React Native has removed createJSModules from ReactPackage so it should be removed.

error: method does not override or implement a method from a supertype
@Override
^
1 error
:react-native-launch-darkly:compileDebugJavaWithJavac FAILED

Question: Why are the variation methods using a callback

Hey @p-janik !
First of all, thank you for creating this package, I'm a new LD user.
I have a quick question.

I noticed that the variation functions require a callback parameter but, by looking at the LD SDK Docs and at the source code, their native implementations seem to be synchronous calls (I guess because the real LD fetch for the features is done in the init method?)
Am I missing something?

Thank you!

Redefinition of 'RCTMethodInfo' when trying to build

I receive the error above when trying to build my project with the LD react-native SDK. After a brief search, it appears that the solution is to change the ordering of import checking for RCTBridgeModule. Instead of:

#if __has_include("RCTBridgeModule.h")
#import "RCTBridgeModule.h"
#import "RCTEventEmitter.h"
#else
#import <React/RCTBridgeModule.h>
#import <React/RCTEventEmitter.h>
#endif

it should be:

#if __has_include(<React/RCTBridgeModule.h>)
#import <React/RCTBridgeModule.h>
#import <React/RCTImageLoader.h>
#else
#import "RCTBridgeModule.h"
#import "RCTImageLoader.h"
#endif

For example, see this same issue on RN image picker: ivpusic/react-native-image-crop-picker#436

ld: framework not found Darkly for architecture x86_64

This happens every time I try to run react-native run-ios. I have attempted to follow both the semi automatic process and the manual process.

I am on RN 0.46

Any suggestions would be very welcome! Thanks!