p3lim-wow/ouf_reputation

Reputation Bar support for oUF layouts

oUF Reputation

This is an addon for the popular MMORPG "World of Warcraft".
It can be downloaded at one of the following sites:

• Curse
• WoWInterface
• Wago
• GitHub

Description

oUF Reputation is a element plug-in made for the unitframe framework oUF. It does nothing by itself, and requires a layout that supports it to function.

It has the following features:

• Reputation bar.
• Tags.

For details on how to implement this in your own layout, please see the wiki:
https://github.com/p3lim-wow/oUF_Reputation/wiki

Feedback

If you have a question, please use the comments section on Curse/WoWInterface.
If you would like to report a bug or contribute to the project, please follow this link to get started.

Legal

Please see the LICENSE file.

ouf_reputation's Issues

Error when tracking Legion Exalted Legion factions

Hey p3lim.
I always get this error when tracking factions in Legion which have the Exalted reward (continue to earn rewards with exalted factions in Legion).

Using the latest version.

1x oUF_lumen\embeds\oUF_Reputation.lua:107: attempt to index local 'colors' (a nil value) oUF_lumen\embeds\oUF_Reputation.lua:107: in function <oUF_lumen\embeds\oUF_Reputation.lua:96> (tail call): ? (tail call): ?

Element not visible on entering world untill reputation window is shown

If you open the Blizzard factions window and then reload the game without doing anything else, the reputation bar will show up.

From what I found out inspecting the code, problem seems to be with the API function GetSelectedFaction().

If you enter the world and ouput the result of this API call you will see the output is incorrect.
Do the same after having opened the reputation window and reload. The ouput will actually be the correct faction index. That means till the reputation window is opened this API call is returning the wrong information.

Line 6:
local name, _, standingID, min, max, value, _, _, _, _, _, _, _, factionID = GetFactionInfo(GetSelectedFaction())

Line 85 on the Visibility function:
local selectedFaction = GetSelectedFaction()

No update on UPDATE_FACTION

The unit tag passed to Update(self, event, unit) is nil on UPDATE_FACTION.

Error setting tag environment in 40000.4-Release

I'm getting this error when oUF_Reputation tries to register its tags:

1x oUF-1.5.2\elements\tags.lua:316: 'setfenv' cannot change environment of given object
oUF-1.5.2\elements\tags.lua:316: in function <oUF\elements\tags.lua:310>
oUF_Reputation-40000.4-Release\oUF_Reputation.lua:61: in function `enable'
oUF-1.5.2\ouf.lua:260: in function `EnableElement'
oUF-1.5.2\ouf.lua:439: in function <oUF\ouf.lua:391>
(tail call): ?:
oUF-1.5.2\ouf.lua:702: in function `Spawn'
_Underscore.Units-4.0.0.1\_Underscore.Units.oUF.lua:775: in main chunk

I tracked it to when the "reputation" tag is getting set. It seems like setfenv fails when called on GetWatchedFactionInfo by oUF. Wrapping GetWatchedFactionInfo with a function in oUF_Rep's tags table cleared the error up.