paambaati/websight

🕷A simple but *really* fast crawler built with Node.js & TypeScript

websight's Issues

Question: Are lines 25-32 necessary for Coverage

I noticed in https://github.com/paambaati/websight/blob/3e64f8d7b048aa5d4639c3c455e96ca7979d46c3/.github/workflows/ci.yml#L33-L49 that lines 25-32 are also included in coverage section of the yaml file.

This would duplicate parts of the process. A couple questions:

1. Can we omit duplicative steps?
2. Can we just omit the testing and collect coverage reports in the case they have already ran by lerna run test for example.
3. Is it possible to break out the notify code climate, collect coverage, sum-coverage, and upload-coverage in separate distinct steps for better logging?

CC_TEST_REPORTER_ID exposued

Hi, I was looking at your code for some stuff. I see you the coverage token exposed.

I'd recommend you read it from github secrets instead of having it committed in code, as it's a clear security risk.

See here for more info https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets