Comments (2)
Unfortunately, it's not possible to ignore approvals from specific members of a team, but here are two potential workarounds:
-
Remove the bot account from both teams and add a
users
list with the bot's name to the rules where you'd like the bot to approve (you can mixusers
andteams
conditions on the same rule.) This may not be possible if the teams are important for other purposes or you are unable to create a new team for the bot account. -
Update the bot to leave a special comment when it approves a PR and then modify the rules where you'd like the bot to approve so that the special comment counts as approval. For example:
- name: code_review requires: count: 1 teams: - DEV_TEAM - name: ops_review options: methods: github_review: true comments: - ":+1:" - "👍" - "==OPS_BOT_APPROVED==" requires: count: 1 teams: - OPS_TEAM
When the bot leaves comment that contains
==OPS_BOT_APPROVED==
, it will only count as an approval for theops_review
rule. Other users can continue to use the default comment strings or GitHub reviews.If you'd like the bot to use GitHub Reviews instead of comments, you can use the
github_review_comment_patterns
option to achieve a similar result.
from policy-bot.
First workaround is not suitable for us, but the 2nd one can be implemented.
Will have to think on how to handle for ops users that part of both teams (This is bcoz of how our Teams are implemented, admins are part of all teams). if you have any suggestions for that let me know.
from policy-bot.
Related Issues (20)
- Allow '=' as comparison operator HOT 1
- Misleading documentation about file path regular expressions HOT 1
- AppID ENV Variable not respected HOT 2
- Confusing behavior with skipped checks. HOT 5
- Add feature to use request more reviewers than required count in case of random-users HOT 1
- [Question] Approval by teams agregator
- Declarative Testing of Policies HOT 5
- Certain merges can lead to ignored commits during evaluation
- Request for Advice on Using Policy Bot in Open Source Projects for Testing, Approving, Merging of PRs HOT 3
- If no rule matches can policy-bot not set a failed status on the PR? HOT 1
- Unable to run policy-bot behind a reverse-prxoy HOT 3
- `common.IsActor()` does not actually use `ctx` and can be simplified.
- Condition for not having specific label(s) HOT 6
- has_successful_status causes review requests while PR has draft status HOT 5
- Status check clarification HOT 2
- Feature Request: Predicate to skip rule if a file was changed HOT 6
- Feature Request: Option to count skipped jobs in has_successful_status HOT 5
- Clarify why users are "disqualified" when approval is ignored
- Create new production Release 🚀 HOT 1
- Connecting lines broken when hiding skipped rules with errors
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from policy-bot.