Giter Site home page Giter Site logo

Comments (2)

bluekeyes avatar bluekeyes commented on September 26, 2024

Unfortunately, it's not possible to ignore approvals from specific members of a team, but here are two potential workarounds:

  1. Remove the bot account from both teams and add a users list with the bot's name to the rules where you'd like the bot to approve (you can mix users and teams conditions on the same rule.) This may not be possible if the teams are important for other purposes or you are unable to create a new team for the bot account.

  2. Update the bot to leave a special comment when it approves a PR and then modify the rules where you'd like the bot to approve so that the special comment counts as approval. For example:

    - name: code_review
      requires:
        count: 1
        teams:
          - DEV_TEAM
    
    - name: ops_review
      options:
        methods:
          github_review: true
          comments:
            - ":+1:"
            - "👍"
            - "==OPS_BOT_APPROVED=="
      requires:
        count: 1
        teams:
          - OPS_TEAM

    When the bot leaves comment that contains ==OPS_BOT_APPROVED==, it will only count as an approval for the ops_review rule. Other users can continue to use the default comment strings or GitHub reviews.

    If you'd like the bot to use GitHub Reviews instead of comments, you can use the github_review_comment_patterns option to achieve a similar result.

from policy-bot.

gpadavala avatar gpadavala commented on September 26, 2024

First workaround is not suitable for us, but the 2nd one can be implemented.
Will have to think on how to handle for ops users that part of both teams (This is bcoz of how our Teams are implemented, admins are part of all teams). if you have any suggestions for that let me know.

from policy-bot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.