pancakebunny-finance/bunny

PancakeBunny helps $cake lovers get more $cakes

bunny's Issues

Add Coinbase Wallet SDK as a SignIn solution

Hey team!

This is a friend from Coinbase Wallet. Can we get added it as another Sign In solution.
Coinbase Wallet supports BNB as a default network making it easier for the user.
SDK is pretty straightforward.

https://docs.cloud.coinbase.com/wallet-sdk/docs

hello,I would like to ask where to check the code for compound interest.

hello, I would like to ask you where to check the code for compound interest. I would like to learn more about bunny's compound interest rules.

Use Local Memory Type Variable Instead of Global Storage Type Variable in Event to Save Gas

Hi, we recently have conducted a systematic study about Solidity event usage, evolution, and impact, and we are attempting to build a tool to improve the practice of Solidity event use based on our findings. We have tried our prototype tool on some of the most popular GitHub Solidity repositories, and for your repository, we find a potential optimization of gas consumption arisen from event use.

The point is that when we use emit operation to store the value of a certain variable, local memory type variable would be preferable to global storage type (state) variable if they hold the same value. The reason is that an extra SLOAD operation would be needed to access the variable if it is storage type, and the SLOAD operation costs 800 gas.

For your repository, we find that the following event use can be improved:

• BunnyPool.sol
  function name: setRewardsDuration
  event name:  RewardsDurationUpdated
  variable:    rewardsDuration->_rewardsDuration

    function setRewardsDuration(uint256 _rewardsDuration) external onlyOwner {
        require(periodFinish == 0 || block.timestamp > periodFinish, "period");
        rewardsDuration = _rewardsDuration;
        emit RewardsDurationUpdated(rewardsDuration);
    }

• VaultBunnyBNB.sol
  function name: setRewardsDuration
  event name:  RewardsDurationUpdated
  variable:    rewardsDuration->_rewardsDuration

    function setRewardsDuration(uint _rewardsDuration) external onlyOwner {
        require(periodFinish == 0 || block.timestamp > periodFinish, "VaultBunnyBNB: reward duration can only be updated after the period ends");
        rewardsDuration = _rewardsDuration;
        emit RewardsDurationUpdated(rewardsDuration);
    }

• VaultFlipToCake.sol
  function name: setRewardsDuration
  event name:  RewardsDurationUpdated
  variable:    rewardsDuration->_rewardsDuration

    function setRewardsDuration(uint _rewardsDuration) external onlyOwner {
        require(periodFinish == 0 || block.timestamp > periodFinish, "VaultFlipToCake: reward duration can only be updated after the period ends");
        rewardsDuration = _rewardsDuration;
        emit RewardsDurationUpdated(rewardsDuration);
    }

• VaultQBTBNB.sol
  function name: setRewardsDuration
  event name:  RewardsDurationUpdated
  variable:    rewardsDuration->_rewardsDuration

    function setRewardsDuration(uint256 _rewardsDuration) external onlyOwner {
        require(periodFinish == 0 || block.timestamp > periodFinish, "VaultQBTBNB: period");
        rewardsDuration = _rewardsDuration;
        emit RewardsDurationUpdated(rewardsDuration);
    }

• VaultRelayInternal.sol
  function name: setRewardsDuration
  event name:  RewardsDurationUpdated
  variable:    rewardsDuration->_rewardsDuration

    function setRewardsDuration(uint _rewardsDuration) external onlyOwner {
        require(periodFinish == 0 || block.timestamp > periodFinish, "VaultRelayInternal: reward duration can only be updated after the period ends");
        rewardsDuration = _rewardsDuration;
        emit RewardsDurationUpdated(rewardsDuration);
    }

• VaultFlipToQBT.sol
  function name: setRewardsDuration
  event name:  RewardsDurationUpdated
  variable:    rewardsDuration->_rewardsDuration

    function setRewardsDuration(uint _rewardsDuration) external onlyOwner {
        require(periodFinish == 0 || block.timestamp > periodFinish, "VaultFlipToQBT: reward duration can only be updated after the period ends");
        rewardsDuration = _rewardsDuration;
        emit RewardsDurationUpdated(rewardsDuration);
    }

• QubitPool.sol
  function name: setRewardsDuration
  event name:  RewardsDurationUpdated
  variable:    rewardsDuration->_rewardsDuration

    function setRewardsDuration(uint256 _rewardsDuration) external onlyOwner {
        require(periodFinish == 0 || block.timestamp > periodFinish, "QubitPool: Not time to set duration");
        rewardsDuration = _rewardsDuration;

        emit RewardsDurationUpdated(rewardsDuration);
    }

Do you find our results useful? Your reply and invaluable suggestions would be greatly appreciated, and are vital for improving our tool. Thanks a lot for your time!

gitignore .DS_store file

it's a mac file and it shouldn't be on a git repo.

Missing test folder

I cant find the test folder with all the tests.. is this intentionally?

Transactions not completing

Hello,

I have deposited BNB and converted it to QBT-BNB tokens, however now I cannot deposit or ZAP anything, what might be causing this? My trust wallet is stuck saying it has 10 unresolved transactions, some of them have lasted 4 days or longer

desparicion de assetss en autoc

tenia una posicion en el autocompounding cake, ha desaparecido sin que yo la liquide, donde esta?
solo me aparece al lp de bnb con cake.

Scammers?