Giter Site home page Giter Site logo

learning's People

Watchers

Jyoti Puri avatar Abhishek Pandey avatar

learning's Issues

All absolute imports should be before relative imports.

Imports like these:

import App from './component/App';
import { createStore, applyMiddleware } from 'redux';

Should be re-written as:

import { createStore, applyMiddleware } from 'redux';
import App from './component/App';

Signup / Login improvements

SIGNUP

  • In DB rename username to email.
  • Add unique key constraint to email field.
  • I should not be able to add invalid email on user profile page.
  • Add primary key constraint on id field (this is required on id field of all tables).
  • If user try to register with same email he should see error Email already registered.
  • If password does not match message should be password do not match.

LOGIN

  • If fails message Email of Password provided is wrong.
  • If server is down message Sorry server experiencing some issue.

Code cleanup

  1. Create separate folder for css file.
  2. Either keep all component *.js files in component folder and remove sub-folders, or create sub-folder for all *.js files.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.