pangratz/ember-data-meta-links-improvements

POC for https://github.com/emberjs/rfcs/pull/160

ember-data-meta-links-improvements's Issues

Can only access relationship links from findRecord, not findAll

Hi, I've been trying to fix this myself but haven't been able to figure it out so far.

When I get a single record with findRecord that has a hasMany relationship, I can request the relationship's links. However, if I use findAll, the relationship's links do not get populated.

Delete with no response body fails

When I do delete with response status code of 204 and no response body I get this:

TypeError: Cannot read property 'meta' of undefined
    at Class.didSaveRecord (store.js:62)
    at Class.superWrapper [as didSaveRecord] (ember.debug.js:24805)
    at store.js:2191
    at Backburner.run (ember.debug.js:294)
    at Class._adapterRun (store.js:2058)
    at store.js:2182
    at tryCatch (ember.debug.js:50954)
    at invokeCallback (ember.debug.js:50969)
    at publish (ember.debug.js:50937)
    at ember.debug.js:40417

Line 62 of store.js tells me that didSaveRecord was accessed where it uses data. So I think the problem is this

ember-data-meta-links-improvements/addon/patches/store.js

Line 45 in b80e15b

didSaveRecord(internalModel, { data }) {

. It should check if data.meta and data._top_level_meta are defined.

Store patch assumes relationships are kind of hasMany and has links

I am getting You tried to get the 'testCase' relationship on a 'execution' via record.hasMany('testCase'), but the relationship is of type 'belongsTo'. Use record.belongsTo('testCase') instead with

...,
relationships: {
   "test-case": {
      id: 5,
      type: "test-case"
   }
}

and this seems to be caused by

ember-data-meta-links-improvements/addon/patches/store.js

Line 18 in b80e15b

pushed.hasMany(name).__update_links(links);

. If I comment out this line error goes away and things work. It actually does two assumptions:

1. there are links (which it doesn't)
2. it is hasMany and not belongsTo