panopticoncentral/jsrt-wrappers

C++ wrapers to simplify working with the JsRT interface to the Chakra JavaScript engine.

jsrt-wrappers's Issues

Error in callback functions

Hi, Paul.
I'm finding some issues when defining a callback for a function property with the wrappers.

1. If I use the function_base to have variable arguments I get an "index out of range" error when it unpacks the arguments (line 2659 of .h):
   value_arguments[index] = value(current); // throws the exception
   value_arguments[index-1] = value(current); //its working for me

2. when using base o any template function wrapper I get stuck in the following situation:
   the jscript code correctly calls a function in the c++ code. There I throw an exception with context::set_exception for some logic problem with the arguments.
   The engine gets in InException state, and so when function::thunk calls from_native to convert the result, the JsRt returns JsErrorInExceptionState and thunk throws another exception over my own (without clearing the exceptions) and I get a fatalErrorException instead of any of the original exceptions.
   Editing the thunk function with this code works for me:

        auto ret = from_native(result, &resultValue);
        if (ret == JsErrorInExceptionState) //ADDED to check the state
            return JS_INVALID_REFERENCE;

        if (ret != JsNoError)

I think it should be done with all the templates.

Thanks for a great wrapper.