pantajoe/revealjs-plugin-social-presence

A reveal.js plugin to support social presence

revealjs-plugin-social-presence's Issues

Document pwgen as dependency

File mikro-orm invokes pwgen, which was missing on my machine. Maybe update the script to check this dependency or document it?

Overlap of chat and annotation modals with footer?

In my presentations, the footer is located on top of the chat/annotate/etc. divs, which prevents, e.g., sending chat messages. Note that my presentations include a div footer with the height of the TOC progress footer to help size calculations of reveal.js.

As workaround I currently use this diff in App.jsx:

@@ -28,7 +28,7 @@ export default function App() {
         lecture ? (
           <>
             {!zenMode && showAnnotationHighlights && config.annotations && <AnnotationEnvironment />}
-            <div className="flex flex-col h-full">
+            <div className="flex flex-col h-5/6">
               <Controls />
               <View />
               {config.cursors && (showCursors || showOnlyGroupCursors) && !zenMode && <CursorCanvas />}

Is there a better way?

error TS2307: Cannot find module 'nest-commander' or its corresponding type declarations

With the new release I now run into this:

app_1            | src/cli.ts:1:32 - error TS2307: Cannot find module 'nest-commander' or its corresponding type declarations.
app_1            | 
app_1            | 1 import { CommandFactory } from 'nest-commander'
app_1            |                                  ~~~~~~~~~~~~~~~~
app_1            | 
app_1            | src/core/user/command/teachers.command.ts:1:40 - error TS2307: Cannot find module 'nest-commander' or its corresponding type declarations.
...
app_1            | Error: Cannot find module 'nest-commander'
app_1            | Require stack:
app_1            | - /usr/src/app/dist/src/core/user/command/teachers.command.js
app_1            | - /usr/src/app/dist/src/core/user/command/index.js
app_1            | - /usr/src/app/dist/src/core/user/user.module.js
app_1            | - /usr/src/app/dist/src/core/core.module.js
app_1            | - /usr/src/app/dist/src/app.module.js
app_1            | - /usr/src/app/dist/src/main.js
app_1            |     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
app_1            |     at Function.Module._load (node:internal/modules/cjs/loader:778:27)
app_1            |     at Module.require (node:internal/modules/cjs/loader:1005:19)
app_1            |     at require (node:internal/modules/cjs/helpers:102:18)
app_1            |     at Object.<anonymous> (/src/core/user/command/teachers.command.ts:1:1)
app_1            |     at Module._compile (node:internal/modules/cjs/loader:1105:14)
app_1            |     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
app_1            |     at Module.load (node:internal/modules/cjs/loader:981:32)
app_1            |     at Function.Module._load (node:internal/modules/cjs/loader:822:12)
app_1            |     at Module.require (node:internal/modules/cjs/loader:1005:19)

Upon yarn install I see this, not sure whether it is related:

warning " > [email protected]" has unmet peer dependency "@types/inquirer@^8.1.3".

Any suggestions?

Reset of default browser CSS padding?

Your plugin resets basic browser CSS defaults, in particular padding/indentation of items in (nested) lists. Is that on purpose?

I had to do this in my CSS:

• https://gitlab.com/oer/oer-reveal/-/commit/e3962cbee18792642eeb6a835f492ceb317b974d
• https://gitlab.com/oer/oer-reveal/-/commit/1951835109e07fdd014c1215ea06da59c63a1432

Different admin approach?

Hi Joe,

as discussed yesterday this is a reminder that the current way to register as teacher is not optimal yet.

Thank you again for this amazing plugin!