Displaying of credo warnings throws "Illegal Argument" error

[pantajoe]

Displaying of credo warnings throws "Illegal Argument" error

[pantajoe]

Turns out, this was a stupid typo 😄
Anyway, i improved the highlight ranges of issues that yield a trigger.
I release a new version that fixes this issue and I'll close this issue for now.

[pantajoe]

Hey! Uh, that is not supposed to happen 😄 Thanks for pointing out that issue. It would be great if you could send me the output of the command mix credo --format json in your workspace. Then, I'll probably be able to fix this issue quite quickly.

[PJUllrich]

Of course! Here's the warning in json format:

{
      "category": "warning",
      "check": "Credo.Check.Warning.ApplicationConfigInModuleAttribute",
      "column": null,
      "column_end": null,
      "filename": "lib/web/controllers/stripe_webhook/stripe_webhook_controller.ex",
      "line_no": 6,
      "message": "Module attribute @webhook_signing_key makes use of unsafe Application configuration call Application.get_env/2",
      "priority": 11,
      "scope": "Web.StripeWebhookController",
      "trigger": "Application.get_env/2"
    }

The warning references a module attribute. It looks something like this:

defmodule StripeWebhookController do

  @webhook_signing_key Application.get_env(:my_app, :webhook_signing_key)

   # ... Other module stuff ...

end

Thank you for having a look at this 🙏