Comments (3)
seems Pants is only identifying changes if made to the HelmChartMetaSourceField
(the "chart.yaml" itself) and not to the HelmChartSourcesField
. I think this is an interaction of things that get a sources field expecting only 1 sources field.
from pants.
Confirming, we get tgt[SourcesField]
. Since the chart itself is a SourcesField
, this getitem gives just the chart.
I remember that we had a similar problem with the Terraform backend, for handling tfvars and tfbackend files. My first pass was to use separate sources fields, which ran into this problem. We ended up creating separate target types, which was also helpful for other terraform things (multiple deployments for the same module). (In theory, we could create this as a synthetic target, since "chart.yaml" is a good indicator that this is a Helm chart.) We could also remove it as a sources field, and pull it in with with a pathglob. (We used to pull in terraform lockfiles with a pathglob, and now we do that with a synthetic target.)
@alonsodomin thoughts?
from pants.
yeah, I think this is a result of the helm_chart
target having two different sources fields. IIRC There was a similar issue reported some time ago in Slack but it never made as a bug report.
Anyway, it's quite likely that some refactoring will be needed in terms of targets, separating the responsibilities of the helm_chart
target into one that points to the Chart.yaml
specifically and another one for capturing the chart sources. I assume the change can be done in a way it doesn't affect end users by preserving the helm_chart
target but converting it to a target generator for the other two.
from pants.
Related Issues (20)
- Support exporting downloaded external tools HOT 1
- method to align install_requires of python_distribution with locked depdencies
- scala reproducibility is broken somwhere between 2.14.2 to 2.20.2 HOT 1
- Hard native parser errors cause 2.22 to fail to start, ignores `native_option_validation=warning`
- Rust options parser fails to parse 1 as float, different to legacy parser HOT 2
- Link to slack does not work HOT 4
- Using poetry as a build tool with python_distribution does not work HOT 3
- docker buildx bake support HOT 1
- pants 2.21: XML files for unit tests executed with pytest are no longer generated HOT 1
- poetry_requirement defined by relative path generates a lockfile with absolute path HOT 8
- pants fails to download golang module from private repo due to missing git binary HOT 2
- Better shell completions HOT 2
- Conflict between docformatter --check and --in-place options when using Pants HOT 5
- Cannot upgrade Pants from 2.19 due to `ModuleNotFoundError` for `pex`. HOT 1
- python.invalid_lockfile_behavior = "ignore" or "warn" does not ignore sha256 mismatches for stale dependencies HOT 4
- Conflicts between architecture of image present on system when building PEX with `docker_environment`
- Docker containers used by a docker_environment are not cleaned when using `--no-pantsd` HOT 1
- macOS 12 GitHub-hosted runners will stop working from 2024-12-03
- native options parser mismatch with quoted strings in env vars. HOT 3
- Consider using executable_search_path in go backend
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pants.