paperback-ios/extensions-common

Common models and type definitions for developing a Paperback source

extensions-common's Issues

[Bug] Errors in Languages interface

It seems there are some errors in the Languages interface for the following constants:

• CHINESE
• CHINESE_HONGKONG
• ISRAELI
• MEXICAN

Some other mentions:

• INDIAN should be HINDI
• Brazilian doesn't exist, its Portuguese
• Mexican doesn't exist, its Spanish
• Malay doesn't exist, if it was intended for Malaysia, it's English
• For Iran it should be PERSIAN with "fa"
• For Philippine it should be FILIPINO and there's only ISO 939-2 three-letter code "fil"
• ISRAELI is not a valid ISO 939-1 code, it should be Hebrew with "he"

And if we want to be accurate with ISO 939-1 two-letter codes (don't know how it's used app side) here are some other adjustments:

• Chinese is not really accurate for ISO 939-1 but might be OK depending on how it's used app side
• For Czech it should be "cs" conforming to ISO 939-1
• Danish should be "da" conforming to ISO 939-1
• Welsh should be "cy" conforming to ISO 939-1
• Greek should be "el" conforming to ISO 939-1
• CHINEESE_HONGKONG = 'hk' is not a valid ISO 939-1 code
• Japanese should be "ja" conforming to ISO 939-1
• Korean should be "ko" conforming to ISO 939-1
• SAMI = 'si' isn't a valid ISO 939-1 code, there is ISO 939-2 code "smi" though. There is Northern Sami with "se" which is the most widely spoken of all Sami languages.
• Ukrainian should be "uk" conforming to ISO 939-1
• Vietnamese should be "vi"
• English should be "en" conforming to ISO 939-1

ISO 939-1 wiki link for reference

.

[REQUEST] Extensions-common suggestions

Referencing @FramboisePi issue Paperback-iOS/app#255 here as a reminder so it can be followed and closed when someone look into these inconsistencies.

[Request] Add more languages

Hey Paperback source devs is it possible to add more languages for sources that use languages like arabic and Farsi etc is it possible to added?

README is incorrect

MangaDex is no longer the primary source so the readme is invalid.

Better documentation

I would love to help the community maintain extensions but I have no time to dissect this entire package and figure out how it works if there was better documentation I feel that we would be able to attract more maintainers for extensions and thereby make the community grow better

I'm not sure I'm posting this in the right place but I think we need better documentation across the board

Gg

Jakejw