Fix builds for 0.7.0

[papierkorb]

Fix builds for 0.7.0

[ZaWertun]

"LLVM_VER" "GREATER_EQUAL" "10"
  Unknown arguments specified

I think it caused by old CMake.

[kalinon]

ah. yeah i ran into this somewhere else. may need to compile it

[docelic]

Given that @ZaWertun added the GenericVersion class which has since been used in a couple more places in bindgen/qt5, how about we simply don't make this check in cmake, but elsewhere?

One option would be to simply extend find_clang.cr so that it accepts two versions from command line and returns the result of comparison (done via GenericVersion) through its exit status.

Or another alternative could be that we ourselves detect and set the c++ standard as part of find_clang rather than expecting cmake to detect and pass it.

[docelic]

GREATER_EQUAL 10 was just fixed by using GREATER 9.

The issue that pops up now is:

In src/bindgen/library.cr:5:1
 5 | require "json_mapping"
     ^
Error: can't find file 'json_mapping'

Is it possible that shards is not being run in these builds?

[kalinon]

probably not. i probably just introduced that build bug.

[HertzDevil]

Looks like builds now fail with

clang: error: -Wl,-fuse-ld=gold: 'linker' input unused [-Werror,-Wunused-command-line-argument]

The culprit may be

bindgen/clang/find_clang.cr

Lines 60 to 63 in 3f02883

	OPTIONS[:llvm_cxx_flags] = output_of(OPTIONS[:llvm_config], "--cxxflags")
	.gsub(/-fno-exceptions/, "")
	.gsub(/-W[^alp].+\s/, "")
	.gsub(/\s+/, " ")

It should be okay to drop linker flags here (-Wl,*) as the generated command line is compile-only (-c):

bindgen/clang/find_clang.cr

Lines 145 to 147 in 3f02883

	build: "#{clang} #{llvm_cxx_flags} #{system_include_dirs.map{ |x| "-I#{File.expand_path(x)}" }.join(' ')}" \
	" -c -o {SPEC_NAME}.o {SPEC_NAME}.cpp -I.. -Wall -Werror -Wno-unused-function" \
	"#{dynamic ? "" : " -fPIC" }",