paramt/memeadviser

A reddit bot that evaluates memes and predicts growth on r/MemeEconomy

Hi there 👋

Hi there! I'm a CS student @ UWaterloo with a passion for exploring technology!

Links

     

memeadviser's Issues

Store memeadviser.log in the repo's wiki

Advantages

The log can be viewed online in real-time

Implementation

One way to do this is to save the log file in MemeAdviser.wiki and run a shell script each time the program runs that looks like this:

#!/bin/bash
cd MemeAdviser.wiki/
git add .
git commit -m "Update log"
git push

Context-awareness

Use Reddit's hot algorithm to ensure the current 2nd and 3rd hot submissions on the front page aren't close to any submissions the bot recommends.

Don't send multiple rounds of PMs within the same hour to prevent spam

Occasionally, the bot comments and sends a PM to everyone minutes apart. Before recommending any memes, the bot should check to make sure that a recommendation was not made in the same hour

Fix 'Try, Except, Pass detected.' issue in app.py

CodeFactor found an issue: Try, Except, Pass detected.

It's currently on:
app.py:54

Use Reddit to save data

Description:

Instead of using replied.txt to keep track of submissions that have already been replied to, we can use reddit's save feature. So writing to file would be replaced by saving a post on Reddit, and accessing that list would be something like:

replied = reddit.user.me().saved(limit=None)

Furthermore, subscribed.txt can be replaced by a text submission in a private subreddit, which can be edited whenever the subscribed list needs to be updated

Advantages:

• The script can run from tests directly, making CI tests simpler and increasing code coverage at the same time

Script takes more than 1 minute to run

Description
The cronjob is scheduled to run every minute, but this is a problem when the bot has to send 100+ PMs because it takes more than 1 minute to execute and is interrupted by the next scheduled job before it gets a chance to finish

MemeAdviser/src/app.py

Lines 121 to 122 in aab7e5a

	for user in subscribed:
	reddit.redditor(user).message("MemeEconomy Update", constants.Messages.pm.format(link=submission.permalink, upvotes=submission.score, break_even=algorithm.break_even(submission.score)))

Possible Solutions

• run-one

Codecov config file not doing anything

The codecov.yml file doesn't seem to be doing anything... codecov is still failing commits and the color range hasn't changed. The file doesn't have to be at root level, so that shouldn't be causing the problem.

I'll test some things out when I get home; just created this issue as a reminder

Use Google sheets to store data files

Use Google Sheets to store subscribed.txt and replied.txt.

Advantages:

• Easier to maintain

Disadvantages:

• An added point of failure

Add code coverage to pytest

If your adding Pytest, may as well add Codecov or Coveralls.io as additional tools.

Automatically update bot algorithm

The algorithm used to calculate investment return and break-even points needs to be the same as the one the r/MemeEconomy bot uses. Instead of using a local copy, the bot should use the official one directly, so that if they were to update it, the bot would stay updated.