pasqualerossi/42-school-exam-rank-05

4th 42 School Exam

42-school-exam-rank-05's Issues

leak and segfault

hi.
thanks for the solutions
in cpp_module_01 there's a leak as some delete was forgotten for the Spell object. i guess in the ForgetSpell function need to add delete _SpellBook[SpellName];

in cpp_module_02 if you change this string to a non existing object name, it segfaults:
ATarget* wall = tarGen.createTarget("Inconspicuous Red-brick Wall non-existent");

i didnt check the reason, but will update if i find.
i failed on exam as i also had the segfault, but now sure if it was the only reason

Exam

JCluzet simulator not compiling cpp_module01

Can't tell if it's an issue with this repo or with the exam simulator, but the solution to cpp_module01 does not compile on the simulator. Here's the traces:

Undefined symbols for architecture x86_64:
  "Warlock::launchSpell(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, ATarget const&)", referenced from:
      _main in main-1418d0.o
  "Warlock::Warlock(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)", referenced from:
      _main in main-1418d0.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

<--------------~-~-~-~-~-~-~-~-~------------>
Richard: This looks like another boring day.$
Richard: I am Richard, the Titled!$
Target Practice Dummy has been fwooshed!$
Richard: My job here is done!$
\n
<--------------~-~-~-~-~-~-~-~-~------------>\n\n
<--------------~-~-~-~-~-~-~-~-~------------>
\n
<--------------~-~-~-~-~-~-~-~-~------------>

Any clue?