pattern-lab/plugin-drupal-twig-components

plugin-drupal-twig-components's Issues

Add create_attribute()

create_attribute() is a new twig function in Drupal core 8.3.x https://www.drupal.org/node/2818293

The Attribute class contains a lot of logic, i am not sure if we should copy it, trim it down or maybe add drupal/core as a composer dependency and use it directly?

Create a decoupled Drupal Twig Extension

Now that patternengine-php-twig provides a way to register proper Twig Extensions (hooray!) we should probably concentrate on creating a Drupal Twig Extension.

The extension should be decoupled from both Drupal and Pattern Lab and usable with all kinds of decoupled Twig/Drupal projects. Maybe something that could be used as a part of the stand-alone implementation discussed in https://www.drupal.org/node/2702061

Not sure what would be the best home for this extension, ideally it would be an official Drupal project.

Include other patterns from .json file

Hi, is that possible to include other patterns from a json file?

I have this list

<div class="node-list">
    {% for node in items %}
        <div class="node-list__item">
            {{ node }}
        </div>
    {% endfor %}
</div>

with this json file

{
  "items": [
    {
      "article": {
        "nid": 10,
        "nodeUrl": "/node/10",
        "title": "Example article teaser",
        "showTime": false
      }
    }
  ]
}

and I want to render the article as another pattern, but I don't want to include this from twig because I'm using render arrays for that on drupal

README and what not

It'd be awesome if we could get some more documentation on this repo. I'd like to highlight it with the full release of Pattern Lab 2. That will be happening early next week (~Jul. 12). Thanks.

Create SECURITY.md

Hello 👋

I run a security community that finds and fixes vulnerabilities in OSS. A researcher (@Rudloff) has found a potential issue, which I would be eager to share with you.

Could you add a SECURITY.md file with an e-mail address for me to send further details to? GitHub recommends a security policy to ensure issues are responsibly disclosed, and it would help direct researchers in the future.

Looking forward to hearing from you 👍

(cc @huntr-helper)

PL - View All not showing all

I think I discovered a bug in Pattern Lab with the view all link.

This bug relates to this PL:

• http://mayflower.digital.mass.gov/
• https://github.com/massgov/mayflower

1. View all link doesn't show up if there aren't any subfolders
   a. The molecules folder didn't originally have a subfolder and as such didn't have a view all link
2. When you click the view all link it only shows patterns that are in sub folder
   a. If you click the view all link in molecules, you'll only see the forms folder patterns.

I also noticed that the main style guide didn't include these patterns either.
http://mayflower.digital.mass.gov/styleguide/html/styleguide.html