paulrberg/evm-bn

Convert fixed-point numbers to ethers big numbers and vice-versa.

evm-bn's Issues

migrate BigNumber to BigInt

Hi @PaulRBerg, would like to open a PR for this, if you think it's a good idea to migrate as ethers now use bigint in v6.

Run coverage and track it via Coveralls

Let "decimals" be zero

BigNumber percentage with calculation with evm-bn

Hello, I'm trying to write some TypeScript versions of functions using PRBMath Solidity Library. One thing I am having trouble with is modeling TypeScript functions the same way as the Solidity ones.

For example, in Solidity you can do something like .25e18 to model 25% out as a Big Number, and multiple X by .25e18 to get 25% of X.

uint256 twentyFivePercent = X.mul(.25e18);

With TypeScript, I have not been able to find an equivalent, even with these wonderful libraries like evm-bn. I believe I'm just doing something wrong here, and would love an example for how I can achieve the above using evm-bn.

Thanks!

Feature request: decimals as optional second argument

Make it possible to provide the number of decimals as an optional second argument. The minimum value permitted should be 1, and the maximum 77.

Feature request: support ability to write more readable decimal number literals

E.g., fp("10,000,000.256") is a lot easier to read than fp("10000000.256").

Some issues with negative exponential numbers (scientific e notation)

I noticed that when representing very small numbers like 10 * 10^-18 (10 with 0 decimals), the following line works: fp("1e-17"), while the following line doesn't fp("10e-18"). Apparently, fp("10e-18") is internally interpreted to be equal to 1 * 10^-18, so does fp("100e-19") and fp("1000e-20").

Feature request: ability to change decimals from it's default value (18)

It would make it easier to represent values in certain contexts. E.g., fp("1", 8) for the following example.
In this feature, 18 would be the default number of decimals (e.g., fp("1") is the same as fp("1", 18)).

Add a function that can unwind the conversion

Turn the current default export into a toBn function, and add a new function fromBn that converts from a BigNumber to a string.