Validation fails on file formData

[payu]

Validation fails on file formData

[igor-savin-ht]

(Updated original issue with correct error as 0.3.2 was hiding actual issue behind new one)

[idanto]

@igor-savin-ht the package indeed doesn't support formData source.
My main goal was to support JSON APIs cause this is what I usually do, but I would be happy to add this case.

Can you please provide a server and a test for this case and I will make a fix for this scenario?

[igor-savin-ht]

Sure, I'll add failing test.

[igor-savin-ht]

@idanto Done.

[idanto]

Thanks @igor-savin-ht

I did a bit of a reading and I'm not sure what should be the expected behavior in your case.
What do you suggest? what would you validate?

[igor-savin-ht]

@idanto I would say that in given case the only important thing is to check that file with given name was sent as a part of request. Worst case scenario, if that is for some reason not possible to check easily - at least it shouldn't fail with error :)

[idanto]

Hi @igor-savin-ht ,

TBH, I don't use multipart/data-form so the package doesn't support it, but I added a suggested solution in merge request #16 - the solution is based on the use of express/multer package as a request parser and it validates both required and optional file names using ajv custom keyword that I created.

Feel free to comment and suggest better solutions or improvements.

[igor-savin-ht]

Thank you very much! I'll make sure to give it a good hard testing after it is merged :D

[idanto]

You can test it even if it is still in a branch using this link in npm install command:
https://github.com/idanto/express-ajv-swagger-validation.git#support-multipart-form-data

[igor-savin-ht]

Cool, will try it out tomorrow, it's 22:42 here, a bit too late to fire up IDE :D

[idanto]

Released in v0.4.0

[igor-savin-ht]

Just tried new version out on our service, works like a charm, thanks!