pazdera/libcity

A C++ library for procedural generation of cities and large urban environments.

libcity's Issues

Minimal distance between intersections

Add checking of the minimal distance between intersections to generating algorithm (RoadLSystem).

MinimalCycleBasis infinite recursion

The following road configuration in StreetGraph causes infinite recursion after calling findZones().
map->addRoad(Path(Line(Point(0,0), Point(100,100))));
map->addRoad(Path(Line(Point(300,500), Point(100,100))));
map->addRoad(Path(Line(Point(300,300), Point(200,400))));

StreetGraph has 6 intersections and 8 roads.

http://www.stud.fit.vutbr.cz/~xpazde00/soubory/screenshot04182011_113609388.jpg

Expected behavior:
Create 0 zones.

precomputeIntersectionsVertices() segfault

Segfault at

==12881== Use of uninitialised value of size 4
==12881==    at 0x46D77AC: Point::x() const (point.h:56)
==12881==    by 0x46D7ADE: Point::Point(Point const&) (point.cpp:34)
==12881==    by 0x46DAFC0: Ray::origin() const (ray.cpp:84)
==12881==    by 0x46DB1ED: Ray::intersection2D(Ray const&, Point*) const (ray.cpp:102)
==12881==    by 0x8059081: OgreCity::precomputeIntersectionsVertices() (ogrecity.cpp:627)
==12881==    by 0x805B973: OgreCity::drawRoadNetwork() (ogrecity.cpp:77)
==12881==    by 0x46F59F9: City::draw() (city.cpp:52)
==12881==    by 0x806A7C9: City3D::createScene() (city3d.cpp:66)
==12881==    by 0x805F826: BaseApplication::setup() (baseapplication.cpp:233)
==12881==    by 0x805FE97: BaseApplication::go() (baseapplication.cpp:202)
==12881==    by 0x806AED8: main (main.cpp:26)
==12881==
==12881== Invalid read of size 8
==12881==    at 0x46D77AC: Point::x() const (point.h:56)
==12881==    by 0x46D7ADE: Point::Point(Point const&) (point.cpp:34)
==12881==    by 0x46DAFC0: Ray::origin() const (ray.cpp:84)
==12881==    by 0x46DB1ED: Ray::intersection2D(Ray const&, Point*) const (ray.cpp:102)
==12881==    by 0x8059081: OgreCity::precomputeIntersectionsVertices() (ogrecity.cpp:627)
==12881==    by 0x805B973: OgreCity::drawRoadNetwork() (ogrecity.cpp:77)
==12881==    by 0x46F59F9: City::draw() (city.cpp:52)
==12881==    by 0x806A7C9: City3D::createScene() (city3d.cpp:66)
==12881==    by 0x805F826: BaseApplication::setup() (baseapplication.cpp:233)
==12881==    by 0x805FE97: BaseApplication::go() (baseapplication.cpp:202)
==12881==    by 0x806AED8: main (main.cpp:26)
==12881==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==12881==
==12881==
==12881== Process terminating with default action of signal 11 (SIGSEGV)
==12881==  Access not within mapped region at address 0x0
==12881==    at 0x46D77AC: Point::x() const (point.h:56)
==12881==    by 0x46D7ADE: Point::Point(Point const&) (point.cpp:34)
==12881==    by 0x46DAFC0: Ray::origin() const (ray.cpp:84)
==12881==    by 0x46DB1ED: Ray::intersection2D(Ray const&, Point*) const (ray.cpp:102)
==12881==    by 0x8059081: OgreCity::precomputeIntersectionsVertices() (ogrecity.cpp:627)
==12881==    by 0x805B973: OgreCity::drawRoadNetwork() (ogrecity.cpp:77)
==12881==    by 0x46F59F9: City::draw() (city.cpp:52)
==12881==    by 0x806A7C9: City3D::createScene() (city3d.cpp:66)
==12881==    by 0x805F826: BaseApplication::setup() (baseapplication.cpp:233)
==12881==    by 0x805FE97: BaseApplication::go() (baseapplication.cpp:202)
==12881==    by 0x806AED8: main (main.cpp:26)

Fillament Roads not considered while extracting blocks/lots

Fillament roads are just removed by Minimal Cycle Basis algorithm and not considered while making blocks and lots. This results in an occasional road underneath a building.

No source code available

Dude, there's no source code available in this project.

DESTDIR convention not supported

It would be nice to consider staged installs and make the Makefile support this convention.

Slow secondary road generation

Secondary road generating is too slow. Most probably due to wrong L-System interpreting algorithm.

Block extraction fail

Block extraction algorithm produces in some situations unsatisfying results. See http://www.stud.fit.vutbr.cz/~xpazde00/soubory/bad_areas.png

Road combination is bugging 3way intersections

This roads in StreetGraph causes fail while creating 3way intersection.

map->addRoad(Path(LineSegment(Point(-300.988, -1852.79, 0), Point(-228.946, -1688.77, 0))));
map->addRoad(Path(LineSegment(Point(-198.41, -1666.19, 0), Point(-228.946, -1688.77, 0))));
map->addRoad(Path(LineSegment(Point(-228.946, -1688.77, 0), Point(-201.985, -1627.38, 0))));

city3d: /home/astro/MyBook/Skola/BP/code/3d/src/ogrecity.cpp:687: void OgreCity::precomputeIntersectionsVertices(): Assertion `intersectionResult == Line::INTERSECTING' failed.