When loading document via 'Downloader' option, SetPages Action may be called incorrectly

[pdftron]

When loading document via 'Downloader' option, SetPages Action may be called incorrectly

[justinjung04]

We tried loading a XOD file with 600+ pages, but we weren't able to reproduce SET_TOTAL_PAGES being triggered multiple times. We also dispatch the action in three event listeners only:

• onBeforeDocument: to get total pages from metadata
• onDocumentUnloaded: to set total pages to 0
• onLayoutChanged: the event name's misleading, but this event gets triggered when pages have permanently been added or removed.

Could you provide more information to help us debug the issue?

[justinjung04]

We also tried loading linearized PDF with 600+ pages, but SET_TOTAL_PAGES was triggered only once.

[henry-chris]

Bah. That's my fault. I thought it happened with XOD, but it only happens using 'Downloader' option. Try it without XOD. EDIT: I will say, the 'Downloader' option is impossible to use with XOD from my understanding. With XOD the only option you are given is 'Streaming'.

…

________________________________ From: Justin Jung <[email protected]> Sent: Tuesday, November 13, 2018 1:00:31 PM To: PDFTron/webviewer-ui Cc: henry-chris; Author Subject: Re: [PDFTron/webviewer-ui] When loading document via 'Downloader' option, SetPages Action may be called incorrectly (#45) We also tried loading linearized PDF with 600+ pages, but SET_TOTAL_PAGES was triggered only once. [image]<https://user-images.githubusercontent.com/18124240/48436340-50381080-e733-11e8-9ecd-bfc24cef89a7.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#45 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AD-QWdivTWmwuDDLoCyesK8p7OQmyPUZks5uuxbPgaJpZM4YX5W1>.

[henry-chris]

Ahh, did not see the last reply. Pdfnetjs with downloader option in version 4.0.1 is what I'm doing. Loading linearized PDF from Azure blob storage. Maybe it was fixed in the 4.0.2.X, I was unable to test that correctly due to a 'withcredentials' issue in the Core. I can try to reproduce on the latest version once I get the fixed version.

…

________________________________ From: Chris Henry <[email protected]> Sent: Tuesday, November 13, 2018 1:39:44 PM To: PDFTron/webviewer-ui; PDFTron/webviewer-ui Cc: Author Subject: Re: [PDFTron/webviewer-ui] When loading document via 'Downloader' option, SetPages Action may be called incorrectly (#45) Bah. That's my fault. I thought it happened with XOD, but it only happens using 'Downloader' option. Try it without XOD.

________________________________ From: Justin Jung <[email protected]> Sent: Tuesday, November 13, 2018 1:00:31 PM To: PDFTron/webviewer-ui Cc: henry-chris; Author Subject: Re: [PDFTron/webviewer-ui] When loading document via 'Downloader' option, SetPages Action may be called incorrectly (#45) We also tried loading linearized PDF with 600+ pages, but SET_TOTAL_PAGES was triggered only once. [image]<https://user-images.githubusercontent.com/18124240/48436340-50381080-e733-11e8-9ecd-bfc24cef89a7.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#45 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AD-QWdivTWmwuDDLoCyesK8p7OQmyPUZks5uuxbPgaJpZM4YX5W1>.

[henry-chris]

After we upgraded and merged to 4.0.2_68331 version.

Example of problem with PDF -

Note that the 'SET_TOTAL_PAGES' happens a LOT more after the picture. Probably one for every partial content download (but I haven't verified this).

PDF can be found here: https://pdfmarkupblobstore.blob.core.windows.net/sample-container/ZierdtRdPhase4.pdf

[henry-chris]

Oh, I missed something from your previous message, sorry.

It's definitely onLayoutChanged.js:

Put a breakpoint in all 3 places. It hits 'onBeforeDocumentLoaded' first (once), then hits the 'onLayoutChanged' every other time (a lot).

If I trace this back, I come first to this function in your minified CoreControls (let me know if you'd prefer me to not post these):

And the Call Stack:

I formatted CoreControls inside the Chrome debugger. CoreControls should be this version - 4.0.2_68331. Hopefully this helps.

[ZhijieZhang]

LayoutChanged event will be triggered when there are pages added, deleted, moved(index of a page changed) or content has changed. When we are downloading linearized PDF, pages will be updated and this event will be triggered. SET_TOTAL_PAGES should be dispatched once in the beginning and not be dispatched in the subsequent page updates. We will fix it and merge to master soon.