Using `snapToOffsets` instead of the custom snap code

[pedrobern]

Using `snapToOffsets` instead of the custom snap code

[andreialecu]

I was able to fix the glitch in #12. I propose we keep the custom snapping code and if someone wants to override they can use disableSnap: true and their own custom snap offsets.

[andreialecu]

I guess one reason for using the custom snap code is the ability to override the snapThreshold.

The native snapToOffsets prop has improved behavior and stops momentum scrolling at the snap points, so the header doesn't peek through before snapping back, which may be preferable. Also snapToEnd needs to be set to false.

[andreialecu]

May need to verify that it doesn't break cases when the tab content slightly overshoots the window size by less than the snap offset, so it doesn't get stuck offscreen with the list snapping back and not allowing access to it.

[PedroBern]

The snapToOffsets indeed looks like a better solution.

[PedroBern]

I did a quick test on the examples folder, adding snapToOffsets={[0, HEADER_HEIGHT]} to all scrollable components and running on the Collapsible Tab View no snap demo, wich has disableSnap={true}, and it looks like working fine for scroll view, but does not work for flatlist.

The flatlist snaps the header and itself.

[andreialecu]

Weird. It works with FlatList in the app I'm working on with no issues. I didn't test the examples folder though, something must be different.

[andreialecu]

@PedroBern make sure to also add snapToEnd={false} otherwise the snap points keep repeating for the rest of the list, resulting in weird scrolling behavior.

[PedroBern]

@PedroBern make sure to also add snapToEnd={false} otherwise the snap points keep repeating for the rest of the list, resulting in weird scrolling behavior.

😝 forgot, I will try it again later

[PedroBern]

@andreialecu Can you make a review of #11, please? There was one thing I didn't understand, after fixing #8 and moving to snapToOffsets if I didn't add this line, the albums tab would double in height.