Giter Site home page Giter Site logo

Comments (6)

jonasgloning avatar jonasgloning commented on May 29, 2024 2

Just released BinaryPack 2.1, which restores support for nested Blobs within objects.

I'll release a beta version of PeerJS today, and if no further issues arise, I will publish the updated version as 1.5.2 in the next days.

from peerjs.

jonasgloning avatar jonasgloning commented on May 29, 2024 1

Ah, it only happens when sending Blobs nested in objects. I'll try to fix it.

from peerjs.

117503445 avatar 117503445 commented on May 29, 2024

peers/js-binarypack#61

from peerjs.

jonasgloning avatar jonasgloning commented on May 29, 2024

There was a bug in v1.5.0, but I believed it had been fixed in v1.5.0. Please help me reproduce the error, as my code runs without any issues.

<html>
  <body>
    <!-- <script src="https://unpkg.com/[email protected]/dist/peerjs.min.js"></script> -->
    <script type="module">
      // Fails with 1.5.0
      // import Peer from "https://esm.sh/[email protected]?bundle-deps";
      // Works with 1.5.1
      import Peer from "https://esm.sh/[email protected]?bundle-deps";
      const peer1 = new Peer();
      peer1.once("connection", (conn) => {
        conn.on("data", (data) => {
          document.write(new TextDecoder("utf-8").decode(data));
        });
        conn.send("Hello!");
      });
      const peer1id = await new Promise(peer1.once.bind(peer1, "open"));

      const peer2 = new Peer();
      peer2.once("open", () => {
        const conn = peer2.connect(peer1id);
        conn.once("open", () => {
          const blob = new Blob(["Blobs are working!"], { type: "text/plain" });
          conn.send(blob);
        });
      });
    </script>
  </body>
</html>

from peerjs.

github-actions avatar github-actions commented on May 29, 2024

🎉 This issue has been resolved in version 1.5.2-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

from peerjs.

github-actions avatar github-actions commented on May 29, 2024

🎉 This issue has been resolved in version 1.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

from peerjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.