Giter Site home page Giter Site logo

django-healthpoint's People

Contributors

ecno92 avatar pennersr avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

django-healthpoint's Issues

django-healthpoint throws deprecation warning in Django 3

Warning:

/usr/local/lib/python3.7/site-packages/healthpoint/urls.py:7: RemovedInDjango40Warning: django.conf.urls.url() is deprecated in favor of django.urls.re_path()

Expected behavior:
For Django 3 users, it does not throw this warning.

Potential Denial of Service vunerability

Healthpoint does the health checks first before checking which user is doing the request. After doing the actual health checks it decides whether the results are allowed to be displayed to the user.
When you are doing a request with a staff member or with the special Basic authentication credentials, you will see the results in the response. Otherwise you just get a status code.

The health checks itself can have some latency as checking connectivity to related services (database, object storage etc.) is a typical use case for this package.

When an attacker knows about the health check endpoint it could in theory create a DoS attack by calling the endpoint without any authentication at a high request rate.

There are several ways how to deal with this problem. According to me introducing a single boolean setting to require basic authentication when basic authentication is configured should be sufficient.

Looking forward to feedback on how to handle this. ๐Ÿ‘

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.