peppercode1/item-model-fix

A Fabric mod that fixes gaps in generated item models.

Item-Model-Fix

A Fabric mod that fixes gaps in generated item models. See the CurseForge page for more information.

CurseForge project page: https://www.curseforge.com/minecraft/mc-mods/item-model-fix

item-model-fix's Issues

Strange performance issues with Pixel optimization

FPS in the top left

It seems like its trying to optimize icons in inventory, its especially apparent with enchanted items.

Same happens with items dropped on the ground

again, enchant glint makes it significantly worse

For comparison, here is outline optimisatio

n

Please update to Minecraft version 1.20 for your mod.

Please update to Minecraft version 1.20 for your mod.

Crashed client

Version mod: new
Minecraft: 1.15.2
Tested and crashed, i can know why crashed - it is modmenu.

Update to 1.19

Mod doesn't fix item model

This texture wasn't connecting properly, and I was just wondering how I could fix it. I tried it on all modes, and no method seems to work. If I could get any feedback that be greatly appreciated!

Here is the actual item texture (blown up to 512x, original texture is 16x):

Here is the texture in game:

Is there any way I can fix this? Thanks!

Single flickering transparent pixels

When using this mod the 1 pixel wide gap in items is fixed, but there are still single pixels that flicker between being transparent and not being transparent. This is probably caused by rounding errors.
It's easier to see with Iris and Sildurs Vibrant Shaders and in movement, but it happens without shaders as well.
I guess the epsilon value needs to be increased.

Mark as working for 1.19 on CurseForge

Working perfectly fine on 1.19:

Port to 1.18.2

Port for fabric 1.18.2

Incompatible with the sodium 1.16.x/next branch

[22:03:44] [main/FATAL]: Mixin apply failed itemmodelfix.mixins.json:SodiumFluidRendererMixin -> me.jellysquid.mods.sodium.client.render.pipeline.FluidRenderer: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @ModifyConstant annotation on onRender0 could not find any targets matching 'render(Lnet/minecraft/class_1920;Lnet/minecraft/class_3610;Lnet/minecraft/class_2338;Lme/jellysquid/mods/sodium/client/model/quad/sink/ModelQuadSinkDelegate;)Z' in me.jellysquid.mods.sodium.client.render.pipeline.FluidRenderer. Using refmap item-model-fix-refmap.json [PREINJECT Applicator Phase -> itemmodelfix.mixins.json:SodiumFluidRendererMixin -> Prepare Injections -> -> constant$ckj000$onRender0(F)F -> Parse]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @ModifyConstant annotation on onRender0 could not find any targets matching 'render(Lnet/minecraft/class_1920;Lnet/minecraft/class_3610;Lnet/minecraft/class_2338;Lme/jellysquid/mods/sodium/client/model/quad/sink/ModelQuadSinkDelegate;)Z' in me.jellysquid.mods.sodium.client.render.pipeline.FluidRenderer. Using refmap item-model-fix-refmap.json [PREINJECT Applicator Phase -> itemmodelfix.mixins.json:SodiumFluidRendererMixin -> Prepare Injections -> -> constant$ckj000$onRender0(F)F -> Parse]

Modrinth page

Having this published on Modrinth would be great, as the only alternative there is limited to 1.16!
Thanks <3

Minecraft 1.19.3 crashes on launch

Recently updated Minecraft to 1.19.3, and I found that the game was unable to start when this mod was loaded. Tested with all other mods except this one, and only with this one.

Logs from the standalone run, it looks like one of the mixins failed.

System info

Minecraft version: 1.19.3
Fabric loader version: 0.14.11
Item Model Fix version: 1.0.3+1.19

Launcher: Prism Launcher 5.2, flatpak version
Java version: 17.0.4.1 (provided with Prism flatpak)
Java memory allocations: 2048 MiB minimum, 4096 MiB maximum

Operating System: Fedora Linux 37
Kernel version: 6.0.11-300.fc37.x86_64
Desktop environment: X11
Processor: Intel Core i5-12600k
Graphics: NVIDIA RTX 3070 Ti
Nvidia driver version: 520.56.06

Pixel generation type conflicts with CIT Resewn

Using Pixel generation type, CIT Resewn, and this resourcepack causes the items the resourepack affects to look weird, and large frame drops when many of them are shown on screen, for example when "enchanted" is searched in the creative menu.

https://www.curseforge.com/minecraft/mc-mods/cit-resewn

https://resource-pack.com/enchantment-textures-resource-pack-1-16-3

What it should look like:

Flickering block intersections with many shaders

This flickering happens with all shaders I've tested so far aside from AstraLex. Some shaders make it more prominent than others. This happens when only sodium 0.5.1, iris 1.6.7, model fix 1.14, and quilted fabric api 7.1.2 is in the mods folder. I just used Ok Zoomer to zoom into the block corner, which makes the effect more noticeable, but it is still visible with a wide FOV. The shaders used in the clip is Complementary Reimagined, but I have also reproduced the issue with BSL, Solas, and Super Duper Vanilla.

Base.Profile.2023.08.19.-.23.37.16.07.mp4

Error in fabric.mod.json, you have an unescaped CRLF in a string value.

itemmodelfix 1.0.1

You either remove the CRLF after "description": "Fixes gaps in generated item models. or escape them with \r\n or \n

My suggestion: remove the CRLF and make the description just one line. That's the whole idea, that the description is a one liner.

Does it work with optifabric

Will this work with optifabric or does it have issues.

Incompatible with 1.17.

When attempting to use this mod in 1.17, the game just loop-loads since the java code is entirely different.