percolate/charlatan

Go Interface Mocking Tool

charlatan's Issues

Method naming conflict with Field and FieldNot.

Similarly named methods can cause auto-generated method naming conflicts. Specifically if an interface has a naming such as:

Field(string, interface{})
FieldNot(string, interface{})

While charlatan does code generation for Field(), it generates FieldCalled() and FieldNotCalled().

When charlatan attempts to generate methods for FieldNot(), it will generate FieldNotCalled() and draw a method definition naming conflict error, as there is already a FieldNotCalled() method defined by code generation for Field().

Type error in generated mock

What did you do?

type Call struct{}

//go:generate charlatan -output ./mockCallsDAL.go CallsDAL
type CallsDAL interface {
	Get(id uint64) (call *Call, err error)
}

What did you expect to see?

Expected generated valid go code or some error

What did you see instead?

In this case, in function "SetGetInvocation" it generates code with a type error.

System details

Package version v1.0.4 ( 4cd615c )

go version go1.10.1 linux/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/tomat/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/tomat/Projects/go"
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build652025093=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version go1.10.1 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.10.1
uname -sr: Linux 4.14.34-1-MANJARO
LSB Version:	n/a
Distributor ID:	ManjaroLinux
Description:	Manjaro Linux
Release:	17.1.8
Codename:	Hakoila
/usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.26, by Roland McGrath et al.

Variable names conflicts it generated mocks

What did you do?

type Type struct{}

//go:generate charlatan -output ./mockTypesDAL.go TypesDAL
type TypesDAL interface {
	Get(id uint64) (t *Type, err error)
}

What did you expect to see?

Expected generated valid go code or some error

What did you see instead?

Generated functions "NewFake*" with name conflicts.
I think it because of the first letter of struct name.

System details

Package version v1.0.4 ( 4cd615c )

go version go1.10.1 linux/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/tomat/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/tomat/Projects/go"
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build652025093=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version go1.10.1 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.10.1
uname -sr: Linux 4.14.34-1-MANJARO
LSB Version:	n/a
Distributor ID:	ManjaroLinux
Description:	Manjaro Linux
Release:	17.1.8
Codename:	Hakoila
/usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.26, by Roland McGrath et al.

Imports Incompatible with Go 1.11 Module Support

charlatan: cannot find package "gopkg.in/olivere/elastic.v5" in any of:
        /usr/local/Cellar/go/1.10.1/libexec/src/gopkg.in/olivere/elastic.v5 (from $GOROOT)
        /Users/tmh/go/src/gopkg.in/olivere/elastic.v5 (from $GOPATH)
service.go:49: running "charlatan": exit status 1

cc @alan-mcnaney

related: go-swagger/go-swagger#1681