Giter Site home page Giter Site logo

Comments (3)

Robdel12 avatar Robdel12 commented on May 25, 2024

Hey Thibaut,

You've hit an unfortunate Chrome bug here. We're hoping Google will correct this upstream so we're not needing to introduce clever hacks. FWIW, Percy is not taking a screenshot on your system. We're taking a DOM snapshot & then collecting the needed assets to render that DOM. Then we render it concurrently across widths & browsers in our own rendering infrastructure.

The best thing we can recommend is to change the vh units to a % based unit using Percy specific CSS. It's not the best fix, but it'll work around this browser bug.

from percy-puppeteer.

Xayah2709 avatar Xayah2709 commented on May 25, 2024

Thanks for your answer. That's infortunate, but I guess we don't have a lot of solution here.

It makes components with vw or vh unreliable to test with Chrome headless. Maybe adding some kind of note in the documentation (docs.percy.io) could be great.

Have you tried that workaround for Percy? puppeteer/puppeteer#703 (comment)

from percy-puppeteer.

Robdel12 avatar Robdel12 commented on May 25, 2024

Closing this one out (it was an infrastructure issue, not specific to an SDK). We have also fixed this almost a year+ ago in the infrastructure 👍🏼

from percy-puppeteer.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.