Comments (3)
Hey Thibaut,
You've hit an unfortunate Chrome bug here. We're hoping Google will correct this upstream so we're not needing to introduce clever hacks. FWIW, Percy is not taking a screenshot on your system. We're taking a DOM snapshot & then collecting the needed assets to render that DOM. Then we render it concurrently across widths & browsers in our own rendering infrastructure.
The best thing we can recommend is to change the vh
units to a % based unit using Percy specific CSS. It's not the best fix, but it'll work around this browser bug.
from percy-puppeteer.
Thanks for your answer. That's infortunate, but I guess we don't have a lot of solution here.
It makes components with vw or vh unreliable to test with Chrome headless. Maybe adding some kind of note in the documentation (docs.percy.io) could be great.
Have you tried that workaround for Percy? puppeteer/puppeteer#703 (comment)
from percy-puppeteer.
Closing this one out (it was an infrastructure issue, not specific to an SDK). We have also fixed this almost a year+ ago in the infrastructure 👍🏼
from percy-puppeteer.
Related Issues (17)
- Capturing a single frame inside a page HOT 2
- percySnapshot sometimes captures part of the page and sometimes full page HOT 6
- Local fonts not loaded on percy rendering environment HOT 6
- More helpful error logging during script injection HOT 3
- Percy agent communication blocked by CSP HOT 7
- PNG images are not displayed HOT 1
- `render.percy.local` error HOT 4
- Error: Caught error after test environment was torn down HOT 1
- During snapshot page is reloaded causing test fail HOT 6
- Support for Jest / use of ES modules dynamic import in SDK HOT 1
- `ReferenceError: window is not defined` with Jest 28 and jest-puppeteer HOT 6
- `@percy/core` development dependency issue HOT 3
- executing percySnapshot on multiple pages HOT 4
- Snapshot requires that the page URL must be HTTP or HTTPS HOT 1
- Improve error message when large DOM is sent HOT 6
- Capturing a selector instead of a page? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from percy-puppeteer.