Giter Site home page Giter Site logo

Comments (6)

frixatrix avatar frixatrix commented on May 24, 2024 1

Hi @Robdel12 thank you for investigating and possible solution.
Will try it out, but as it's not a persistent issue I will be able to confirm it in some time in future (as not going to spend another 15% of screenshots for this 😄 )

from percy-puppeteer.

Robdel12 avatar Robdel12 commented on May 24, 2024

Hey @frixatrix would you be able to share a Percy build link where this is happening?

from percy-puppeteer.

frixatrix avatar frixatrix commented on May 24, 2024

Hey @frixatrix would you be able to share a Percy build link where this is happening?

Hey @Robdel12 could you please share your e-mail for this?
Thank you in advance.

from percy-puppeteer.

Robdel12 avatar Robdel12 commented on May 24, 2024

No problem! You can send the build link over to [email protected]

from percy-puppeteer.

frixatrix avatar frixatrix commented on May 24, 2024

Hi @Robdel12 thank you. Sent email with details.

from percy-puppeteer.

Robdel12 avatar Robdel12 commented on May 24, 2024

Thanks for sending that over! This one is interesting -- it looks like the SDK isn't capturing the font in the default asset discovery timeout window. By default our SDKs will wait 125ms for zero network requests to be made by the DOM snapshot we've captured. Sometimes assets aren't requested in that timeout (I think that's what's going on here). You can increase this timeout by either passing a CLI flag (percy exec -t 250 -- [test command]) or by creating a Percy config file. For example, as a .percy.yml file:

version: 1
agent:
  asset-discovery:
    network-idle-timeout: 250 # ms

This should clear this up. It's safe to take that timeout up to ~500ms (anything higher means there's probably something else going on).

from percy-puppeteer.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.