peronio-ar / core Goto Github PK
View Code? Open in Web Editor NEWPeronio Core
Home Page: https://peronio.ar
License: MIT License
Peronio Core
Home Page: https://peronio.ar
License: MIT License
Based on lines Peronio.sol#L208-L212
i think that the user could end with more MAI than its supposed to, consider changing;
uint256 usdcAmount;
(usdcAmount, ) = _zapOut(lpAmount);
uint256 maiAmount = IERC20(MAI_ADDRESS).balanceOf(address(this));
To
(uint256 usdcAmount, uint256 maiAmount) = _zapOut(lpAmount);
On Peronio.sol#L369-L370 the comment says;
// Add 18 precision decimals
But then you use 10e18;
lpAmount.mul(10e18).div(IERC20(LP_ADDRESS).totalSupply());
Is this comment wrong?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.