peter279k/green-button-converter

This is the Green Button Data Converter with Node.js

green-button-converter's Issues

Green Button XML data validation error

After validating the sample Green Button data test.xml, it presents the incorrect validation message.

It's as follows:

Schema validation error: The 'http://naesb.org/espi:start' element is invalid - The value '2019-07-18 17:00:00' is invalid according to its datatype 'http://naesb.org/espi:TimeType' - The string '2019-07-18 17:00:00' is not a valid Int64 value.
at line number:44 position:41

It looks like the start date should use the int64 type.

That is, the start date should be the timestamp.

Test enhancement

As title, I think we can consider using the XML Parser to validate the Green Button XML data.

We can consider the XML data has the following expected behavior:

• The entry tags should have the 3 blocks.
• The content tags should have the 3 blocks.
• The published tags should have the 3 blocks.
• The updated tags should have the 3 blocks.

Add support for Atom XML elements required by the NAESB REQ.21 ESPI standard

Add ElectricPowerUsageSummary blocks

As title, we also consider adding this ElectricPowerUsageSummary blocks for customers to know their billing of power usage.

Enhance the ISO string

According to the Green button data references, it should be the ISO_8601 string in Published and Updated tags.

For example, looking at the following code snippets:

> moment().utc().format("YYYY-MM-DD[T]HH:mm:ss[Z]")
'2019-07-21T18:16:20Z'

But the time string is as follows at this moment:

2019-07-19T13:25:14+08:00

@fogdingding. This code snippets should be fixed :).

ISO_8601 string reference

• https://stackoverflow.com/questions/25725019/how-do-i-format-a-date-as-iso-8601-in-moment-js

Update README

As title, since the PR #1 is merged, we can consider updating the Green Button XML data in README.

Enhance Green button data output

As title, it seems that the Green Button XML data output is wrong.

Considering this reference and enhance them.

Add electric meter id number on options JSON object

As title. And this number should present on title tag in Green Button Data response.